Skip to content

Daily dead-code sweep 2026-10-12: createWatch's unused id/open getters #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EnesYilmazcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Daily dead-code sweep 2026-10-12: createWatch's unused id/open getters #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions js/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,9 +1142,6 @@ export function diagnosticsBlock(d) {
export function createWatch({ geolocation, visible, onFix, onError, options = {} }) {
let id = null;
return {
// Read-only on purpose: a caller that can assign the handle can lose it.
get id() { return id; },
get open() { return id != null; },
// Returns why it did what it did, so a test can tell "refused" from "opened"
// without reaching for the handle.
start(origin) {
Expand Down
9 changes: 3 additions & 6 deletions scripts/test/follow.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,6 @@ test('the handle it clears is the handle it opened', () => {
geo.watchPosition = () => 7;
const w = createWatch({ geolocation: () => geo, visible: shown, onFix() {}, onError() {} });
w.start(gps);
assert.equal(w.id, 7);
w.stop();
assert.deepEqual(geo.calls.clear, [7], 'the watch was cleared by a handle it never held');
});
Expand All @@ -410,7 +409,6 @@ test('stopping drops the handle, so the watch can come back', () => {
const w = createWatch({ geolocation: () => geo, visible: shown, onFix() {}, onError() {} });
w.start(gps);
w.stop();
assert.equal(w.open, false);
assert.equal(w.start(gps), 'open', 'a handle left set refuses every restart for the session');
assert.equal(geo.calls.watch.length, 2);
});
Expand All @@ -421,7 +419,7 @@ test('a throw inside clearWatch still drops the handle', () => {
const w = createWatch({ geolocation: () => geo, visible: shown, onFix() {}, onError() {} });
w.start(gps);
assert.equal(w.stop(), 'stopped');
assert.equal(w.open, false, 'a failed stop must not strand the handle');
assert.equal(w.start(gps), 'open', 'a failed stop must not strand the handle');
});

test('a hidden page never opens a watch', () => {
Expand Down Expand Up @@ -453,12 +451,11 @@ test('the watch stays coarse and refuses a cached fix, read off the options it i
test('an unsupported or throwing geolocation leaves no handle behind', () => {
const bare = createWatch({ geolocation: () => ({}), visible: shown, onFix() {}, onError() {} });
assert.equal(bare.start(gps), 'unsupported');
assert.equal(bare.open, false);
assert.equal(bare.stop(), 'closed', 'an unsupported geolocation must not believe a watch opened');
const thrower = createWatch({ geolocation: () => ({ watchPosition() { throw new Error('no'); } }),
visible: shown, onFix() {}, onError() {} });
assert.equal(thrower.start(gps), 'threw');
assert.equal(thrower.open, false, 'a throw must not leave the app believing a watch is live');
assert.equal(thrower.stop(), 'closed');
assert.equal(thrower.stop(), 'closed', 'a throw must not leave the app believing a watch is live');
});

test('js/app.js owns no watch handle of its own any more', () => {
Expand Down
Loading