Skip to content

Daily dead-code sweep 2026-10-10: the gesture teardown nothing calls #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EnesYilmazcode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Daily dead-code sweep 2026-10-10: the gesture teardown nothing calls #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c6e85d
Drop the gesture teardown nothing can call
claude Oct 10, 2026
0809991
Re-measure the shell after the gesture teardown came out
claude Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ sits at the bottom, then **Add to Home Screen**. iOS 26 defaults to that Compact
layout, which is why the app offers you both. On Android, Chrome has **Install
app** in its menu.

Installed, the whole app is 164 KB of shell and about 112 KB of schedule, gzipped, and
Installed, the whole app is 165 KB of shell and about 112 KB of schedule, gzipped, and
none of it is fetched again to answer a question. Turn the network off, open it,
and it still ranks rooms. That matters because the moment you want it most is the
moment you are in a basement with one bar.
Expand Down
12 changes: 0 additions & 12 deletions js/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,6 @@ const TAP_MS = 300;
// pinch over the map zooms the whole page on iOS and the two fight.
export function attachGestures(canvas, { onPan, onZoom, onTap } = {}) {
const pointers = new Map();
const priorTouchAction = canvas.style.touchAction;
canvas.style.touchAction = 'none';

let rect = null;
Expand Down Expand Up @@ -706,15 +705,4 @@ export function attachGestures(canvas, { onPan, onZoom, onTap } = {}) {
canvas.addEventListener('pointercancel', up);
canvas.addEventListener('wheel', wheel, { passive: false });
window.addEventListener('resize', invalidate);

return () => {
canvas.removeEventListener('pointerdown', down);
canvas.removeEventListener('pointermove', move);
canvas.removeEventListener('pointerup', up);
canvas.removeEventListener('pointercancel', up);
canvas.removeEventListener('wheel', wheel);
window.removeEventListener('resize', invalidate);
canvas.style.touchAction = priorTouchAction;
pointers.clear();
};
}
6 changes: 3 additions & 3 deletions sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
// One cache would either re-download the room index on every deploy or pin an
// installed icon to last month's app.js forever.
//
// Measured on 2026-09-16 over the committed blobs, which is the copy Pages serves:
// `git show HEAD:<file> | gzip -9 -c | wc -c`. Shell 167,466 bytes, data 115,160.
// Measured on 2026-10-10 over the committed blobs, which is the copy Pages serves:
// `git show HEAD:<file> | gzip -9 -c | wc -c`. Shell 168,778 bytes, data 116,297.
// Run it exactly as written, through the pipe. `gzip -9 -c <file>` with the
// name as an argument stores each basename in the gzip FNAME header and reads
// 176 bytes higher across these seventeen files, which is most of a percent of
Expand Down Expand Up @@ -88,7 +88,7 @@
// placeholder is __BUILD_ID__, and a committed sw.js still carrying it means the
// stamp did not run. scripts/test/sw.test.mjs fails on exactly that. Spelled out
// rather than built from CACHE_PREFIX, because the stamper rewrites this line.
const SHELL_CACHE = 'vacant-shell-c09a7c8';
const SHELL_CACHE = 'vacant-shell-5c6e85d';
const DATA_CACHE = 'vacant-data-v1';

// CacheStorage is per origin, not per path, and enesyilmazcode.github.io also
Expand Down
Loading