Skip to content

Daily dead-code sweep 2026-10-08: unused generation getter on the directions object #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EnesYilmazcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Daily dead-code sweep 2026-10-08: unused generation getter on the directions object #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions js/directions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,12 @@ export function createDirections({ key, consent = () => false, maps = loadMaps,
const ready = () => (consent() && globalThis.navigator?.onLine !== false ? maps(key, doc) : Promise.reject(new Error('unavailable')));

return {
// Bumped by the caller whenever the origin or the date moves. A response
// that comes back against an old generation is dropped rather than
// rendered, which is the rule docs/research/walking-routes-115.md sets: a
// stale answer must never reorder or relabel a list already on screen.
get generation() {
return generation;
},
// Bumped by the caller whenever the origin or the date moves, and handed
// back so the caller can tell generations apart without this object
// keeping a second, readable copy of the count. A response that comes
// back against an old generation is dropped rather than rendered, which
// is the rule docs/research/walking-routes-115.md sets: a stale answer
// must never reorder or relabel a list already on screen.
invalidate() {
generation += 1;
return generation;
Expand Down
2 changes: 0 additions & 2 deletions scripts/test/directions.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,8 @@ test('an answer against an old generation is dropped', async () => {
test('invalidate counts up so a caller can tell generations apart', () => {
const { maps } = fakeMaps({ leg: LEG });
const d = createDirections({ key: 'k', consent: yes, maps });
assert.equal(d.generation, 0);
assert.equal(d.invalidate(), 1);
assert.equal(d.invalidate(), 2);
assert.equal(d.generation, 2);
});

// --- the matrix, all or nothing
Expand Down
Loading