Skip to content

Use a general course search placeholder #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KadyrovAkram merged 1 commit into from
Oct 23, 2026
Merged

Use a general course search placeholder #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/generator-render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function renderGenerator({
const input = el("input", "f-ctl");
input.setAttribute("id", "gen-course");
input.type = "text";
input.placeholder = "CSE 24 or systems";
input.placeholder = "Course number or name";
input.autocomplete = "off";
input.setAttribute("aria-autocomplete", "list");
input.setAttribute("aria-controls", "gen-suggestions");
Expand Down
1 change: 1 addition & 0 deletions tests/generator-render.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ test("the builder exposes clear constraints and only available ranking prioritie
const page = setupDom();
const view = renderGenerator(options());
page.document.body.append(view);
assert.equal(view.querySelector("#gen-course").placeholder, "Course number or name");
assert.equal(view.querySelectorAll(".gen-course-chip").length, 2);
assert.equal(view.querySelectorAll(".gen-weight input").length, 5);
assert.match(view.textContent, /Open seats/);
Expand Down
Loading