Skip to content

Use Barrett instructor listings before OSU publishes them - #138

Merged
KadyrovAkram merged 3 commits into
mainfrom
feature/barrett-instructor-fallback
Sep 16, 2026
Merged

KadyrovAkram merged 3 commits into
mainfrom
feature/barrett-instructor-fallback

Conversation

@KadyrovAkram

@KadyrovAkram KadyrovAkram commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

  • Preserve the instructor column that the Barrett snapshot parser already reads.
  • Use the Barrett listing only when the live Ohio State response has no primary instructor.
  • Keep explicit Barrett roles such as TA, SI, GR, GY, LA, and GS from being promoted to professor.
  • Ignore short-session markers such as {7W2} that share the trailing fixed-width column.
  • Refresh the Autumn 2026 and Spring 2027 snapshots with instructor data.
  • Document the fallback and add parser, loader, compatibility, and contract tests.

Why

Finder already used Barrett for seats and linked sections, and the parser already extracted instructor names. The snapshot writer discarded those names, so Finder still waited for the Ohio State class API before showing an instructor. Keeping the field lets a course search show the earlier Barrett assignment without replacing the official assignment when it arrives.

Compatibility

Older three-value seat rows still work. Rows only gain a fourth value when Barrett contains a valid instructor listing.

Verification

  • npm test
  • 734 passed, 23 skipped, 0 failed
  • git diff --check

@KadyrovAkram
KadyrovAkram merged commit c0a1cb1 into main Sep 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant