Skip to content

Remove test on release - #91

Merged
tsmbland merged 2 commits into
mainfrom
86_remove_test_release
Aug 24, 2026
Merged

Remove test on release#91
tsmbland merged 2 commits into
mainfrom
86_remove_test_release

Conversation

@dalonsoa

Copy link
Copy Markdown
Contributor

Description

So tests in this repository are only run against the main branch of MUSE2. Whenever there's a new release of MUSE2, there should be a release with matching number here, and just instruct people they should use the right version when analysing their data.

Close #86

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Copilot AI lite review requested due to automatic review settings August 20, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies CI to only test against the MUSE2 main branch by removing the reusable “test-with-muse2” workflow and the action that downloads MUSE2 release binaries, and inlining the remaining test job directly into ci.yml.

Changes:

  • Removed the reusable workflow that supported testing against either MUSE2 main or MUSE2 “latest release”.
  • Inlined the pytest matrix job into ci.yml and standardized on installing MUSE2 from main.
  • Removed the composite action that downloaded and configured MUSE2 from the latest upstream release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test-with-muse2.yml Deleted reusable workflow that parameterized testing against MUSE2 main vs release.
.github/workflows/ci.yml Inlined the test matrix and fixed CI to always install MUSE2 from main; adjusted triggers and Codecov upload gating.
.github/actions/setup-muse2-release/action.yml Deleted action that downloaded the latest MUSE2 release asset and set MUSE2_PATH.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 20, 2026 14:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/ci.yml:46

  • The Codecov upload is currently gated on github.event_name == 'release', so coverage (and the Codecov badge for the default branch) will not update on normal push/schedule CI runs. If the intent is to keep coverage reporting up-to-date for mainline CI, consider uploading once (Linux only) for all non-PR runs instead of only on release events.
      - name: Upload coverage to Codecov
        # Latest linux release only - they should all be the same
        if: runner.os == 'Linux' && github.event_name == 'release'

@dalonsoa

Copy link
Copy Markdown
Contributor Author

Naturally, tests are failing since it is out of date with the current output of MUSE2. I suggest we merge this PR and then work on adapting the code here... again :)

@tsmbland

Copy link
Copy Markdown
Contributor

Naturally, tests are failing since it is out of date with the current output of MUSE2. I suggest we merge this PR and then work on adapting the code here... again :)

I've opened an issue: #92

@dc2917 dc2917 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@tsmbland
tsmbland merged commit e641092 into main Aug 24, 2026
3 of 7 checks passed
@tsmbland
tsmbland deleted the 86_remove_test_release branch August 24, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable running CI in release after the next release

4 participants