Remove test on release - #91
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies CI to only test against the MUSE2 main branch by removing the reusable “test-with-muse2” workflow and the action that downloads MUSE2 release binaries, and inlining the remaining test job directly into ci.yml.
Changes:
- Removed the reusable workflow that supported testing against either MUSE2
mainor MUSE2 “latest release”. - Inlined the pytest matrix job into
ci.ymland standardized on installing MUSE2 frommain. - Removed the composite action that downloaded and configured MUSE2 from the latest upstream release.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/test-with-muse2.yml | Deleted reusable workflow that parameterized testing against MUSE2 main vs release. |
| .github/workflows/ci.yml | Inlined the test matrix and fixed CI to always install MUSE2 from main; adjusted triggers and Codecov upload gating. |
| .github/actions/setup-muse2-release/action.yml | Deleted action that downloaded the latest MUSE2 release asset and set MUSE2_PATH. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/ci.yml:46
- The Codecov upload is currently gated on
github.event_name == 'release', so coverage (and the Codecov badge for the default branch) will not update on normalpush/scheduleCI runs. If the intent is to keep coverage reporting up-to-date for mainline CI, consider uploading once (Linux only) for all non-PR runs instead of only on release events.
- name: Upload coverage to Codecov
# Latest linux release only - they should all be the same
if: runner.os == 'Linux' && github.event_name == 'release'
|
Naturally, tests are failing since it is out of date with the current output of MUSE2. I suggest we merge this PR and then work on adapting the code here... again :) |
I've opened an issue: #92 |
Description
So tests in this repository are only run against the
mainbranch of MUSE2. Whenever there's a new release of MUSE2, there should be a release with matching number here, and just instruct people they should use the right version when analysing their data.Close #86
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))