Skip to content

docs: 新增仓库协作与审查规范 - #54

Merged
YuShenLiu06 merged 6 commits into
fix/issue-49-results-layoutfrom
docs/review-guidelines
Oct 18, 2026
Merged

YuShenLiu06 merged 6 commits into
fix/issue-49-results-layoutfrom
docs/review-guidelines

Conversation

@YuShenLiu06

@YuShenLiu06 YuShenLiu06 commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

一句话说明

新增协作与审查规范,记录布局验收不变量、证据分层、审查轮次与授权整合规则;现已合入用户确认的 #53 边界修复,P2:需人工验收。

用户要测什么

  • 阅读 AGENTS.md 与 REVIEW.md:显式检查相关技能并跟随目录符号链接;文档/技能冲突时按当前代码和配置校准。
  • 核对布局应覆盖稳定边界、短/长/空内容及小视口,截图须对照用户目标,不得只改文档绕开未满足需求。
  • 审查轮数不应掩盖新发现且有证据的阻塞问题;独立功能默认并行,允许用户明确授权统一验收堆叠。
  • 文档增量无独立运行时/UI 路径;本轮已完成 #55 的产品组合回归,完整最终包仍待独立模板 PR 纳入。

详细变更

  • base 保持 fix/issue-49-results-layout(#53),相对 base 仅为 AGENTS.md / REVIEW.md 两个文档、74 行新增。
  • 本轮整合前 b51585dfc6cb4d8725be33dc7573d64e301911b2 → 整合后 e732a2058e98282276685660871757ba8eda61b3;merge 双亲为原 HEAD 与已通过用户边界验收的 7315c91510a495e329fc17f7709094c6c85b66d9;作者 YuShen LiuYuShen06@outlook.com。
  • 保留原文档作者的布局总结、符号链接发现、三轮审查规则、授权堆叠例外及当前证据校准规则;没有另改产品实现。
  • 本批沿用现有验收链:main → #53 → #54 → #55,未改 Stack56 关联。功能逻辑独立,stack 仅用于统一验收,不声称业务/代码依赖;三个 PR 均为正常 ready/open,保留 P2: 需人工验收。
  • 用户已确认 7315c91 的稳定下边界修正通过,并已确认旧 d4796e9 的框选通过;据此正常 merge 53→54→55。最终顶层 HEAD c45454b860f8bbc2ad776bc0d49e9e2015026c94,tree 155ce80a828addda94cda9b69cf232b3e12f78c3。
  • 两次 merge 无冲突;顶层逐文件 blob/mode 精确保留最新 53、最新 54 文档和既有 55 框选的并集,共 20 个文件。普通 fast-forward push,无 rebase/force push;main 仍为 368d7861f516b0c9245dde0562bdf3ef02388ed9,未合入 main、改分支保护、发布或部署。
  • 模板普通节点化由独立任务继续开发,本版本尚未包含该新 PR,不能作为完整最终发行包;由协调者安排其基于新 55 正常同步。本任务未操作用户本地验收进程。

自证内容

  • 当前 HEAD e732a205 的 CI #79 success;自动审查摘要 的代码与安全均对应当前 SHA completed、均无发现/无未解决发现。
  • 整合前 b51585d 的双审完成且无新发现,但自身没有新 CI;未拿旧 9495599 的 CI 当作该版本证据。本轮证据已使用新 merge SHA 的 CI 与双审。没有手动重复触发。
  • 本轮最终顶层 c45454b:Python 3.12.14 / 3.13.5 的 python -m pytest -q 各 80 passed、无 skip;Node 原几何 66 项、框选几何 13 项通过;全部应用 JS node --check、Python AST、git diff --check、规范文档本地链接及精确文件并集校验通过。
  • 云端隔离 Flask + Chromium,使用一次性配置与合成材料:框选 60/60、布局组合 47/47、普通编辑/模板 68/68,三套页面 JS 异常均为 0。布局流程选用刚经框选变换、保存并覆盖重开的六点轨迹,验证两功能共存。
  • 实际每日 FIT 生成与下载 1→90→1:1600×900 时左右容器底边始终 825.125px,结果卡底边始终 808.125px,页面高度始终 900px;固定表头、末行、滚动链隔离、提示消失、重生成归零通过。四模式 × 9 组窗口(含 961px 断点、390px 手机与 240px 矮窗)以 1→1000→1 行验证稳定边界;1000 行为前端压力 fixture,不冒充实际生成。
  • 同一轨迹另实际生成下载总量 6 FIT、单文件 1 TCX、指定日期 22 TCX,核对下载文件数/扩展名;框选覆盖八柄、旋转后局部缩放、撤销重做、取消/失焦/越界、退化轴、保存及刷新;原普通模式、模板与 FIT/TCX 流程亦回归通过。
  • 最新顶层的框选、短结果、长结果三张脱敏截图已查看并成功交付本对话 Library;均未入 Git、未公开到 GitHub。未公开坐标、个人内容、网络记录、trace 或旧受限证据包。
  • 真实本地 Flask 保存/生成/下载已验证;真实高德 JS API/Key、外网瓦片影像、原生 WebView、Windows/macOS 打包安装均未测。外部影像/字体在布局流程中主动阻止;灰色底图不代表影像通过。
  • 本 PR 自身为文档增量;以上运行时证据来自最终顶层组合版本。未以 CI 或自动化代替用户本人验收,未授权合入 main。

@YuShenLiu06 YuShenLiu06 added the P2: 需人工验收 普通功能或规范变更;最终版本须用户本人验收确认后合并。风险分级,不代表处理先后。 label Oct 18, 2026 — with ChatGPT Codex Connector
YuShenLiu06 added a commit that referenced this pull request Oct 18, 2026
@YuShenLiu06
YuShenLiu06 changed the base branch from main to fix/issue-49-results-layout October 18, 2026 09:21
@YuShenLiu06
YuShenLiu06 added this pull request to stack #56 October 18, 2026 09:27
@YuShenLiu06
YuShenLiu06 marked this pull request as ready for review October 18, 2026 09:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T09:56:49.601486Z e732a20 New commits
🔒 Security Review ✅ Completed 2026-10-18T09:57:44.692141Z e732a20 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34f5b63b29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread REVIEW.md Resolved
Comment thread AGENTS.md Resolved
Comment thread REVIEW.md Resolved

Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 9495599646

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9495599646

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md Resolved
Comment thread AGENTS.md Resolved

Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: b51585dfc6

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: b51585dfc6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

YuShenLiu06 added a commit that referenced this pull request Oct 18, 2026
@YuShenLiu06
YuShenLiu06 merged commit bdd338a into main Oct 18, 2026
1 check passed
@YuShenLiu06
YuShenLiu06 deleted the docs/review-guidelines branch October 18, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2: 需人工验收 普通功能或规范变更;最终版本须用户本人验收确认后合并。风险分级,不代表处理先后。

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant