Resolve conflicts for #187: replace any in trade and dispute tests - #190
Merged
Merged
Conversation
Use typed mocks and fixtures in matching trade and dispute test files, eliminate all no-explicit-any warnings, and ensure the tests pass. Closes #30
…-in-trade-lifecycle-suite-#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflict resolution for #187 (ObedChibunna's
backend-tests-replace-any-mock/fixture-types-in-trade-lifecycle-suite-#30). Merging this also marks #187 as merged, since its commits are included.maininto the PR branch.backend/src/lib/metrics.ts: the PR branch had a duplicatedadvicekey in the event-listener lag histogram options; kept a singleadviceblock (explicit bucket boundaries preserved).backend/src/test-deps.d.ts: unioned both sides: kept the PR's typed ioredis surface and added main'sstatus/on.Evidence
tsc --noEmitinbackend: 10 errors, versus 12 on currentmain(the twoRedis.evalerrors inidempotency.tsgo away); no new errors.🤖 Generated with Claude Code