TransferFundsModal: Coin selection, fee selection#538
Open
RodriFS wants to merge 2 commits into
Open
Conversation
RodriFS
force-pushed
the
add-coin-selection-to-transfer-modal
branch
from
July 24, 2026 11:12
3b64c60 to
f2e09e2
Compare
imclvr
reviewed
Jul 24, 2026
RodriFS
marked this pull request as draft
July 24, 2026 11:25
RodriFS
force-pushed
the
add-coin-selection-to-transfer-modal
branch
from
July 24, 2026 11:43
f2e09e2 to
6870f71
Compare
RodriFS
marked this pull request as ready for review
July 24, 2026 11:43
Contributor
|
I think this deserves its own bUnit tests. |
imclvr
previously approved these changes
Jul 24, 2026
RodriFS
force-pushed
the
add-coin-selection-to-transfer-modal
branch
from
July 24, 2026 13:01
6870f71 to
45131ea
Compare
Contributor
Author
I did my best, but Blazorise is not compatible with bunit 😭. It's impossible to mock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the inlined modal for transferring funds into it's own file. Then adds new functionality to it so it has the same features as the Withdrawal modal. I will create a following PR so we can use this file as the common modal for both views (will add an option to transfer to a random address or select a wallet, didn't want to add it here where is not necessary yet)
Stacked PRs