splice: Make feerate opening + feerate_offset#9109
Open
ddustin wants to merge 1 commit intoElementsProject:masterfrom
Open
splice: Make feerate opening + feerate_offset#9109ddustin wants to merge 1 commit intoElementsProject:masterfrom
ddustin wants to merge 1 commit intoElementsProject:masterfrom
Conversation
ddustin
force-pushed
the
ddustin/splice_feerate_fix
branch
2 times, most recently
from
47aa874 to
a4f9cb6
Compare
ddustin
force-pushed
the
ddustin/splice_feerate_fix
branch
from
a4f9cb6 to
137eac0
Compare
Splicing feerate was being derived by `default_feerate` which was actually `unilateral_feerate`, which is incorrect. Instead we define an explicit `splice_feerate` in the chain topology that is `opening` + `feerate_offset`. This slipped through testing because regtest isn’t a great test of fees we see in the wild. Changelog-Fixed: Fixes high fee issue that caused `splicein` and `spliceout` to abort.
ddustin
force-pushed
the
ddustin/splice_feerate_fix
branch
from
137eac0 to
1b70776
Compare
ddustin
added
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splicing feerate was being derived by
default_feeratewhich was actuallyunilateral_feerate, which is incorrect.Instead we define an explicit
splice_feeratein the chain topology that isopening+feerate_offset.This slipped through testing because regtest isn’t a great test of fees we see in the wild.
Changelog-Fixed: Fixes high fee issue that caused
spliceinandspliceoutto abort.Fixes #9105