Skip to content

Askrene: Reservation leak under load#8993

Open
ScuttoZ wants to merge 2 commits intoElementsProject:masterfrom
ScuttoZ:test-pr8681
Open

Askrene: Reservation leak under load#8993
ScuttoZ wants to merge 2 commits intoElementsProject:masterfrom
ScuttoZ:test-pr8681

Conversation

@ScuttoZ
Copy link
Copy Markdown
Collaborator

@ScuttoZ ScuttoZ commented Mar 26, 2026

Important

26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.

RC1 is scheduled on March 23rd

The final release is scheduled for April 15th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Summary

@madelinevibes madelinevibes added the QA Blockstream QA team have reproduced, or a test has been created! Look for the linked PR/Issue label Mar 26, 2026
@ScuttoZ ScuttoZ added this to the 26.06 milestone Apr 8, 2026
@ScuttoZ ScuttoZ force-pushed the test-pr8681 branch 2 times, most recently from db53bc4 to c318789 Compare April 14, 2026 15:32
@cdecker
Copy link
Copy Markdown
Member

cdecker commented May 4, 2026

Rebased on top of master to see if it passes.

@madelinevibes madelinevibes added Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. PLEASE clear CI 🫠 labels May 7, 2026
@madelinevibes madelinevibes requested a review from Lagrang3 May 7, 2026 09:40
@Lagrang3
Copy link
Copy Markdown
Collaborator

Lagrang3 commented May 7, 2026

The first 2 commits are from another PR they can be removed.
Also I think the last commit was introduced by mistake, please don't remove my simple regression test.

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
@Lagrang3
Copy link
Copy Markdown
Collaborator

Lagrang3 commented May 8, 2026

@ScuttoZ, tests were failing with the concurrent payments' futures timing out.
I've increased the timeout 10 fold.

Copy link
Copy Markdown
Collaborator

@Lagrang3 Lagrang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ScuttoZ.
Keep bringing those tests!

@ScuttoZ ScuttoZ added Status::Release Ready ✅🤩 and removed Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. PLEASE clear CI 🫠 labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Blockstream QA team have reproduced, or a test has been created! Look for the linked PR/Issue Status::Release Ready ✅🤩

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants