Fix replay export dropping equipment details and air bases - #695
Merged
myangelkamikaze merged 2 commits intoAug 28, 2026
Merged
myangelkamikaze merged 2 commits into
myangelkamikaze merged 2 commits into
Conversation
Replay export flattened equipment down to the plain id, dropping Level and AircraftLevel. The noro6 export reads the same SortieRecord.FleetData and carries both, so the data was there all along. Add stars/ace to ReplayShip, kept index aligned with equip, and collapse the four duplicated fleet mappings into ToReplayFleet/ToReplayShip.
MapAreaId holds the world, not the map, so the filter dropped every air base whenever the two differed - which is most sorties. On the 58-4 fixture all three air bases disappeared from the export.
Member
|
I was able to reproduce the issue you described and confirmed that your fix works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated bugs, one commit each.
Equipment improvement and proficiency were dropped.
ToReplayDataflattened every equipment slot down to its plain id, losingLevelandAircraftLevel. The noro6 export reads the sameSortieRecord.FleetDataand carries both, so the data was already there.ReplayShipnow hasstarsandace, index aligned withequipthe wayconvert.jsexpects. The four copy-pasted fleet mappings are collapsed intoToReplayFleet/ToReplayShipso that alignment only has to hold in one place.Air bases disappeared from most sorties. The filter compared
MapAreaIdagainstsortie.Map, butMapAreaIdholds the world. On the 58-4 fixture all three air bases vanished.Tests added in
ElectronicObserverCoreTests/Replay/ReplayExportTests.cs, reusing the existingSortieDetailfixtures; the air base case fails against the old filter withExpected: 3, Actual: 0. Full suite: 475 passed, 0 failed, 24 skipped.