Repository navigation
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Eigenwise
left a comment
There was a problem hiding this comment.
Routed review of head 1af503c merged onto develop 3ead47a. Requesting changes on one point; the rest checks out.
- Default-off state is not byte-identical. With no Antigravity configuration and all proxy model probes pending, develop's startup
/v1/modelsreturns fivenullrows; this branch returns five populated Codex rows. Root:request-worker.js:1145, the initialmodelCachechanged.map(gatewayModel)to.map((id) => gatewayModel(id)). That's a real fix of an existing startup bug, and I want it, but it ships inside a 6,300-line opt-in feature while SKILL.md says "Legacy Codex/Grok behavior is unchanged". Please split that one-line fix into its own small PR (with its own test and fragment) and drop or qualify the "unchanged" sentence here.
What passed: 893 tests / 882 pass / 11 platform skips in an isolated home; the five pre-existing modified test files also pass on develop. Opaque thinking/signature carriers and tool replay stay byte-exact on the two-hop path; reserved selectors, [1m] and OpenAI paths fail locally before any generation or fallback. The new supervisor spawns, kills and listens on nothing and writes no settings; the new process sites (archive extraction, --version, native auth status, explicit login/logout) are bounded; incoming auth/cookie/control headers are stripped by the relay allowlist; no control-token printing. All 1,189 changed bodies measured, every new or raised one CC ≤ 5; CRAP coverage is UNVERIFIED on our side because the capture binding wasn't taken, which is our debt, not yours.
Two smaller notes, not blocking: commands.catalogContextWindow hard-codes 200000 next to the policy table that already carries it (derive it instead), and the relay/discovery, onboarding and test-infrastructure parts would review faster as separate PRs.
Whether model-gateway should carry a native Gemini provider at all is a maintainer decision I'll take to Kenny separately; this review is only the technical side.
|
Direction call from Kenny (2026-11-09): yes, model-gateway will carry a native Antigravity provider, as an experimental, default-off backend. So this is wanted, and the open point is still the one from the October review: please split the one-line startup fix in |
1af503c to
c8079cd
Compare
…eardown tests Trim support.test.js to product-exercising fixture shutdown and diagnostic cases, drop scaffolding-only owned-teardown-tree.js and readRecordedGatewayPid seam/export, register testContext cleanup on live-child tests, bound the held worker /v1/models probe window explicitly, and drop commit: from EigenwiseGH-827.
Rebase onto current develop (stacked on EigenwiseGH-827), derive Antigravity catalogContextWindow from MODEL_WINDOW_POLICY via gatewayAdvertisedWindow, and drop PR narration from SKILL.md and docs.
c8079cd to
11810be
Compare
|
Addressed in
|
Summary
Add opt-in gateway routing for the experimental native Antigravity provider in claude-code-proxy. Native implementation remains separate: raine/claude-code-proxy#185 . This frontend neither imports account credentials nor implements another Google authentication client.
MODEL_WINDOW_POLICY, fixed model/tier/profile sessions and no[1m]promise.Current head
11810be86is rebased ontodevelop(7350b1919, including merged#820) and stacked on standalone startup-catalog/fixture-isolation PR #827 (f7dc66d57) so default-off/v1/modelsis byte-identical todevelop(2dfdd7f47/SQ-4102) and#827's test-only files drop out of this diff once#827merges.Local verification
docs/scripts/content.test.mjs8/8 passed; generated reference files were not hand-edited.#827).Strict local measurement uses the read-only Quality Gate V8 capture binding (
plugins/quality-gate/lib/core.mjs). No Quality Gate source, dependency, threshold, exclusion or CI-policy change is bundled here.Windows follow-up and acceptance boundaries
Earlier hosted Windows runs exposed two test assumptions: configuration expectations used the process drive instead of the injected cwd, and startup-policy assertions took a snapshot before the first authoritative catalog refresh. The standalone startup fallback catalog test and fixture-home isolation/teardown diagnostics have been split out into #827 .
Prior acceptance verification on the feature implementation:
GATEWAY_NATIVE_OK,end_turn, 50 input / 10 output tokens, zero tool calls and zero fallback. No inference retry or second generation phase was used.The live phase is closed and cannot be resumed. This proves the narrow text route, not all tiers/media, measured large context, or live Claude-CLI tool execution. Actual native-provider SSE/tool continuation proof remains separate from the frontend's synthetic client replay.
Release reference
This external contribution uses
.release/unreleased/GH-644.md(bump: minor,plugins: [model-gateway]); the development release guard passes without findings. No manifest version, tag or changelog was hand-edited.Tests use isolated synthetic homes/ports and public-only inputs. No existing serving stack, account credential store or user settings were replaced/reconfigured. No deployment, upstream approval or merge is implied.