fix(ide): resolve Win32 error 193 on Windows and support WSL UNC paths - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves an issue on Windows where attempting to launch an IDE (such as VS Code) fails with
"%1 não é um aplicativo Win32 válido. (os error 193)"(ERROR_BAD_EXE_FORMAT), and adds support for UNC / WSL folder paths (\\wsl. localhost\...).Root Cause
PATHforcode, Windows installations of VS Code include an extensionless POSIX shell script (bin/codefor Git Bash/Cygwin) alongsidecode.cmd. CodeLaunch was pickingbin/codeand attempting to spawn it viaCreateProcessW, which fails because it is not a valid Win32 PE binary..cmdexecution: Spawning.cmdor.batfiles directly via Rust'sCommand::newfails under WindowsCreateProcessWwithoutcmd.exe /c.cmd.exedoes not support UNC paths (\\wsl.localhost\...or\\wsl$\...) withcd /d.Changes
vscode/mod.rs):resolve_cli_pathon Windows to check for valid executable extensions (.exe,.cmd,.bat) instead of accepting extensionless files.Code.exe,Cursor.exe, etc.) inknown_candidatesanduser_candidates.vscode/mod.rs):.exetargets (e.g..cmd,.bator fallback aliases) incmd.exe /cwithCREATE_NO_WINDOWflag.terminal/mod.rs&vscode/mod.rs):resolve_folder_pathto treat UNC prefixes (\\and//) as absolute paths across platforms.pushdinstead ofcd /din generated Windows terminal scripts when pointing to UNC / WSL paths.Verification
cargo test).npm run build).launch_commandarguments.