Repository navigation
Conversation
… launcher for bench Fixes Edge0-AI#209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #209
Two places in the docs pointed somewhere the binary did not go:
--vram-reserve-mib, and the engine accepts it, butstrata.exe --helpnever listed it. Added the missing line tousage()ingenerate.cpp, next to--peer-reserve-mib. The tuning sweep reads its flag list from--help, so this also makes the flag visible there.strata bench runexists only in the Terminal launcher (bin/strata), not in the engine binary, which answersunknown argument: bench. The protocol doc, the community guide, and the closing line oftools/strata_bench.pyall said barestrata bench runwith no hint whichstratathey meant. They now name the Terminal launcher and note the engine binary has nobenchsubcommand.No README change: the capacity table was already right.
Area
edge0-infer/)edge0-infer/tools/assets/)edge0-infer/examples/)docs/)How was it tested?
--helptext from theusage()literals and ran the tuning flag-inventory regex over it:--vram-reserve-mibis now listed.python3 -m py_compile tools/strata_bench.pypasses;pytest edge0-strata/tests/tuning/test_tuning.pypasses (37 tests).--helpwas verified from the source, not from a built binary. CI is the gate for that.Checklist
ctest --preset cpu -L "L0|L1"passes locally inedge0-infer/(engine changes)edge0-infer/docs/testing.md)