Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Asset construction hashed each registered source for lock verification and immediately hashed it again for the initial snapshot, adding a complete read pass over model weights.
Take the initial snapshot once and reuse its digests to verify the lock before conversion. Keep the independent final snapshot to detect source changes during conversion.
Area
Model asset tools (
edge0-infer/tools/assets/).How was it tested?
10 tests passed with Python 3.12/NumPy 2.3.5. The counted-hash regression measures two source reads (initial/final snapshots) rather than three on main. Existing digest mismatch, missing input, converter failure, preservation and provenance checks pass. Full model conversion throughput was not measured.
All 14 L0 checks passed in a local integration with the other focused fixes.
git diff --checkpassed.Checklist
ctest --preset cpu -L "L0|L1"passes locally