use opus-mini instead of -nano - #183
Open
Samueru-sama wants to merge 1 commit into
Open
Samueru-sama wants to merge 1 commit into
Samueru-sama wants to merge 1 commit into
Conversation
Contributor
|
that PR was reverted for now... it might be better to just use a bundled static opus? |
Contributor
Author
Nah |
Contributor
|
why? all other platforms use static opus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are the same package
opus-nanohas been kept around for backwards compat.However since we are working on adding multi-arch support, I will also be dropping the old package names in the near future.
Also does the appimage even contain
libopusnow? Eden was updated to rely on ffmpeg for this. IIRC ffmpeg only needs libopus to encode, not decode.