Skip to content

lint: exclude revive var-naming instead of suppressing it per file #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmannislands wants to merge 1 commit into from
Open

lint: exclude revive var-naming instead of suppressing it per file #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ issues:
- linters:
- revive
text: "if-return"
- linters:
- revive
text: "var-naming"
2 changes: 1 addition & 1 deletion api/services/control/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package moby_buildkit_v1 //nolint:revive
package moby_buildkit_v1

//go:generate protoc -I=. -I=../../../vendor/ -I=../../../../../../ --gogo_out=plugins=grpc:. control.proto
2 changes: 1 addition & 1 deletion api/services/registry/copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package earthly_registry_v1 //nolint:revive
package earthly_registry_v1

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion api/services/registry/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package earthly_registry_v1 //nolint:revive
package earthly_registry_v1

//go:generate protoc -I=. -I=../../../vendor/ -I=../../../../../../ --gogo_out=plugins=grpc:. registry.proto
2 changes: 1 addition & 1 deletion api/services/registry/proxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package earthly_registry_v1 //nolint:revive
package earthly_registry_v1

import (
"bytes"
Expand Down
2 changes: 1 addition & 1 deletion api/services/registry/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package earthly_registry_v1 //nolint:revive
package earthly_registry_v1

import (
"fmt"
Expand Down
2 changes: 1 addition & 1 deletion api/types/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package moby_buildkit_v1_types //nolint:revive
package moby_buildkit_v1_types

//go:generate protoc -I=. -I=../../vendor/ -I=../../../../../ --gogo_out=plugins=grpc:. worker.proto
2 changes: 1 addition & 1 deletion frontend/gateway/pb/caps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package moby_buildkit_v1_frontend //nolint:revive
package moby_buildkit_v1_frontend

import "github.com/moby/buildkit/util/apicaps"

Expand Down
2 changes: 1 addition & 1 deletion frontend/gateway/pb/exit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package moby_buildkit_v1_frontend //nolint:revive
package moby_buildkit_v1_frontend

import (
"fmt"
Expand Down
2 changes: 1 addition & 1 deletion frontend/gateway/pb/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package moby_buildkit_v1_frontend //nolint:revive
package moby_buildkit_v1_frontend

//go:generate protoc -I=. -I=../../../vendor/ -I=../../../../../../ --gogo_out=plugins=grpc:. gateway.proto
1 change: 0 additions & 1 deletion solver/errdefs/solve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ func init() {
typeurl.Register((*Solve)(nil), "github.com/moby/buildkit", "errdefs.Solve+json")
}

//nolint:revive
type IsSolve_Subject isSolve_Subject

// SolveError will be returned when an error is encountered during a solve that
Expand Down
2 changes: 1 addition & 1 deletion sourcepolicy/pb/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package moby_buildkit_v1_sourcepolicy //nolint:revive
package moby_buildkit_v1_sourcepolicy

//go:generate protoc -I=. --gogofaster_out=plugins=grpc:. policy.proto
2 changes: 1 addition & 1 deletion sourcepolicy/pb/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package moby_buildkit_v1_sourcepolicy //nolint:revive
package moby_buildkit_v1_sourcepolicy

import (
"github.com/gogo/protobuf/proto"
Expand Down
2 changes: 1 addition & 1 deletion sourcepolicy/pb/json_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package moby_buildkit_v1_sourcepolicy //nolint:revive
package moby_buildkit_v1_sourcepolicy

import (
"encoding/json"
Expand Down
2 changes: 1 addition & 1 deletion util/apicaps/pb/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package moby_buildkit_v1_apicaps //nolint:revive
package moby_buildkit_v1_apicaps

//go:generate protoc -I=. -I=../../../vendor/ -I=../../../../../../ --gogo_out=plugins=grpc:. caps.proto
2 changes: 1 addition & 1 deletion util/entitlements/security/security_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func getFreeLoopID() (int, error) {
}
defer fd.Close()

const _LOOP_CTL_GET_FREE = 0x4C82 //nolint:revive
const _LOOP_CTL_GET_FREE = 0x4C82
r1, _, uerr := unix.Syscall(unix.SYS_IOCTL, fd.Fd(), _LOOP_CTL_GET_FREE, 0)
if uerr == 0 {
return int(r1), nil
Expand Down
Loading