Repository navigation
Conversation
…heck it v1.12.2's release failed on all six platforms: tauri build refused to start because five plugins were a minor apart between npm and Rust. The Dependabot commit's npm update had moved @tauri-apps/plugin-autostart, -deep-link, -dialog, -opener and -process ahead, and their crates stayed where they were. Nothing before tauri build compares the two, so tests, tsc and cargo check were all green, and only the release itself found out. The same release had also left package-lock.json on 1.12.1, because the version bump never wrote that file. - The five crates move to the npm side's minors: autostart 2.7.0, deep-link 2.6.3, dialog 2.8.4, opener 2.7.2, process 2.4.0, all past the 7-day cooldown. That drops 61 old crates from Cargo.lock, among them rand 0.7.3, one of the open Dependabot alerts, and the unmaintained fxhash. - package.json and Cargo.toml now state the versions that are actually locked, rather than floors several minors below them. - scripts/check-lockfiles.mjs (npm run check:lockfiles) fails when an @tauri-apps package and its crate are on different minors, when package-lock.json no longer matches package.json, or when the six places that carry the version disagree. With --staged it reads the git index, which is how /commit's preflight runs it. The Tests workflow runs it first, in the Changelog job, where it takes seconds instead of a release matrix. - cargo test and clippy run with --locked, so a Cargo.lock that no longer fits Cargo.toml fails CI instead of being re-resolved on the runner. Against the commit before this one, the check reports exactly the five pairs from the release log plus the stale lockfile version. On this tree it passes, clippy is clean, 237 Rust tests pass, and a local tauri build gets through the version check and builds a release binary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.12.2's release failed on all six platforms: tauri build refused to start because five plugins were a minor apart between npm and Rust. The Dependabot commit's npm update had moved @tauri-apps/plugin-autostart, -deep-link, -dialog, -opener and -process ahead, and their crates stayed where they were. Nothing before tauri build compares the two, so tests, tsc and cargo check were all green, and only the release itself found out. The same release had also left package-lock.json on 1.12.1, because the version bump never wrote that file.
Against the commit before this one, the check reports exactly the five pairs from the release log plus the stale lockfile version. On this tree it passes, clippy is clean, 237 Rust tests pass, and a local tauri build gets through the version check and builds a release binary.