Repository navigation
Conversation
Opening the cloud sign-in dialog wrote a fresh link nonce and then read it back, in the same effect, to build the account URL. In Svelte 5 that read makes the effect depend on the value it just wrote, so every run scheduled the next one: a new nonce and another browser tab each time, until Svelte threw effect_update_depth_exceeded and left the dialog frozen. A Mac log showed exactly that error right after the session expired. The reset-and-open now runs untracked, so only `open` triggers it. The first component test checks the browser opens exactly once; it fails with the same error against the old code. vitest gains the svelteTesting plugin so components mount with Svelte's client build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The mock was declared without parameters, so tsc typed its calls as empty tuples and rejected reading the URL from the first one. vitest does not typecheck, which is why it passed locally; `npx tsc --noEmit` now passes too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.