Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion .claude/commands/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,38 @@ Replace the line `## [Unreleased]` (at the top of the Unreleased section) with:

This preserves an empty Unreleased section for future work and stamps the release with today's date.

## Step 5 — Commit
## Step 5 — Check the screenshot goldens

A release commit is the last chance to catch a stale golden before CI fails on it. The screenshot
tests compare the UI against committed PNGs in `app/src/testDebug/screenshots/`, so any change to a
Compose screen — a new row, a reworded string, a spacing tweak — makes the matching golden wrong.
Nothing in an ordinary build catches this: `./gradlew test` only checks that every screen still
composes, so a stale golden passes locally right up until `ci.yml` runs `verifyRoborazziDebug`.

Work out whether that is likely for this release — did it touch the UI or any user-visible string?

```
git diff --stat $(git describe --tags --abbrev=0)..HEAD -- 'app/src/main/kotlin/**/ui/**' 'app/src/main/res/values/strings.xml' 'app/src/testDebug/screenshots/'
```

If UI or strings changed but the `screenshots/` folder did not, tell the user the goldens are
probably stale and confirm it:

```
./gradlew :app:verifyRoborazziDebug --tests '*ScreenshotTest'
```

On failure, look at the `_compare` images in `app/build/outputs/roborazzi/` and check the diff is
the intended change rather than a regression, then accept the new look:

```
./gradlew :app:recordRoborazziDebug --tests '*ScreenshotTest'
```

The `--tests` filter is not optional, and recording locally is legitimate — see AGENTS.md's
"Screenshot tests" for both points. Include the updated PNGs in the release commit.

## Step 6 — Commit

Run:
```
Expand Down
34 changes: 34 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,37 @@ jobs:
name: lint-report
path: app/build/reports/lint-results-debug.html
retention-days: 14

# The landing page only deploys from main, so without this a broken Liquid tag or SCSS
# variable would reach the live site before anyone found out. Same build action as
# pages.yml, so a pass here means that workflow will get through too.
#
# Deliberately no `needs: detect` — the site does not involve Gradle.
pages:
name: Pages Site
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Build the site
uses: actions/jekyll-build-pages@v1
with:
source: ./docs/pages
destination: ./_site

# Do NOT assert that _site/CNAME exists — it never will. `github-pages build` forces
# `exclude => ["CNAME"]` whenever the site's own `exclude` is Jekyll's default, so the
# official builder strips it on purpose. The custom domain comes from the repository's
# Pages settings, not from a file in the artifact, which is why coilforphoniebox.app has
# been resolving all along without it.
#
# Worth knowing that a local `jekyll build` does copy CNAME, having no such rule, so this
# difference does not show up until it runs here.
- name: Check the pages and stylesheet rendered
run: |
test -s ./_site/main.css || { echo "::error::main.css missing or empty"; exit 1; }
test -f ./_site/index.html || { echo "::error::index.html missing"; exit 1; }
test -f ./_site/privacy/index.html || { echo "::error::privacy page missing"; exit 1; }
grep -q 'galleryItem' ./_site/index.html || { echo "::error::screenshot galleries did not render"; exit 1; }
grep -q 'deviceFrame' ./_site/index.html || { echo "::error::hero device frame did not render"; exit 1; }
if grep -q '{%' ./_site/index.html; then echo "::error::unrendered Liquid tag left in index.html"; exit 1; fi
9 changes: 8 additions & 1 deletion .github/workflows/google-play.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ jobs:
serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}
packageName: app.coilforphoniebox
releaseFiles: release-assets/*.aab
track: ${{ inputs.track }}
# `tracks`, not `track`: the action warns that the singular form is deprecated, and
# refuses outright if both are set. It takes a comma-separated list; this workflow
# deliberately passes exactly one, which is why its own input stays singular.
#
# It must never arrive empty — the action defaults to *production* when neither input
# is given, which is not a default anything here should fall into by accident. Hence
# the `|| 'internal'` as well as the input's own default.
tracks: ${{ inputs.track || 'internal' }}
whatsNewDirectory: whatsnew/
mappingFile: release-assets/mapping.txt
Loading
Loading