Repository navigation
fix: version viewer assets to avoid stale inspector scripts - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing browsers could reuse the pre-inspector
esip-contract.jsafter a deployment because the map referenced an unversioned URL. Station clicks then continued opening the embedding app’s layer editor even though the current server supplied chart metadata and inspector code.Add content fingerprints to all MC2-owned viewer JavaScript and CSS URLs, and require revalidation of the map HTML. This keeps each map page paired with the current interaction code while retaining stable URLs for unchanged assets and preserving reverse-proxy path prefixes.
Validation: 6 browser tests pass, including a real Chromium HTTP-cache regression that first reproduces the failure using the previous contract, then opens the inspector with versioned URLs in the same browser context. Also passed 9 API/hash checks and the 2 existing root-path checks. No EOGPT computation or interruption behavior changes.