Repository navigation
feat: add a metadata-driven map asset inspector - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an asset with
metadata.extra.inspectornow opens an anchored viewer for its charts, images, links, and description. Applications supply typed content references; the map owns presentation and selection without introducing station- or analysis-specific asset types.allow-scriptssandbox.ui=default, or independently withinspect=1for embedded maps. Emitasset_click.inspector_handledso embedders can suppress duplicate UI, and preserve embed options when creating a viewer session.update_metadata, validated descriptors, atomic metadata merges, and broadcasts for updates and deletion. Persist attachment references for reloads and reconnects.Validation: 26 focused API/SDK tests and five browser tests pass. A real MapLibre/Plotly browser smoke test with synthetic observations verified anchoring, content updates, expansion, dismissal, reload persistence, visibility/deletion, and mobile/dark layouts.
Merging to main uses the existing multiarchitecture container publication workflow. EOGPT's companion integration (https://github.com/AMA-Labs/eo-gpt/pull/172) opts into this viewer and attaches drill chart references to its existing point assets.