Conversation
…ptional IntroJS. Point CI at e2e/spec.cy.js with an explicit supportFile, add visitGeoweaver/skipIntroIfPresent helpers, and stop requiring .introjs-skipbutton when the tour never appears after localhost login. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cypress/cypress/e2e/spec.cy.js, which hard-requires.introjs-skipbuttonand never logs in.geoweaver.login_required=true, visits land on localhost-login, so IntroJS never mounts → 12/13 tests fail.e2e/spec.cy.js, setsupportFile/specPatternincypress.config.js, and usevisitGeoweaver+skipIntroIfPresentso login is handled and intro is dismissed only when present.Test plan
cd cypress && npx cypress run --spec e2e/spec.cy.jsagainst a running Geoweaver with password123456Made with Cursor