Repository navigation
[Web] Fix points graph scrolling in the browser demo - #144
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling the main page with Points Graph expanded in
try.htmlcould pull the page back toward the phone and compress the chart as the phone moved out of view. The graph now keeps the full phone layout inside a clipped cover and moves with the phone; size observers reposition popups without scrolling the page back.Adds wheel gesture regressions at desktop and mobile widths for page position, unchanged chart dimensions, movement with the phone, and independent filter scrolling. Updates the demo documentation with the layout and observer rules.
Validation:
iphone-demo-popup-qa.cjsandiphone-demo-visual-qa.cjspassed locally in Chromium and WebKit. The popup suite covers all 16 phone presentations. JavaScript syntax checks andgit diff --checkpassed.