Repository navigation
Fix security checks rejecting legitimate users and harden API validation - #1
Merged
Merged
Conversation
ELF-Nigel
force-pushed
the
fix/security-validation
branch
from
October 27, 2026 13:11
0fd4b83 to
10464e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legitimate users could be rejected by startup/watchdog races, sleep/resume timers, PE/instruction heuristics and CDN DNS rotation. Malformed JSON handling was also disabled, while failed login responses could still mark local authentication state.
This change restores JSON exceptions, requires signed successful authentication before sealing local state, isolates API instances, owns background thread lifetime, and replaces unreliable runtime enforcement with TLS/signature/server-session validation. It also corrects request encoding, file GET selection, HTTP/signature diagnostics, checksum handling and pin configuration. Missing or invalid authentication signatures remain rejected.
Validation: Release x64 library built locally with MSVC v145; five regression executables passed (headers, Ed25519, checksums, JSON errors, lifecycle/form encoding). Windows CI runs the same tests.
Draft pending live application testing. Consumers must rebuild with the updated headers and handle request exceptions. The API 1.3 endpoint/signing key are unchanged. Upstream unsigned file responses retain TLS-only behavior; dependency binary provenance and full dependency updates remain separate work.