Adding groups logic and restrictions - #454
Open
AgentScrubbles wants to merge 5 commits into
Open
Conversation
AgentScrubbles
marked this pull request as ready for review
July 29, 2026 16:26
DecDuck
requested changes
Jul 30, 2026
DecDuck
left a comment
DecDuck
left a comment
Member
There was a problem hiding this comment.
A couple of nitpicks for maintainability.
| if (!group) | ||
| throw createError({ statusCode: 404, message: "Group not found" }); | ||
|
|
||
| // eslint-disable-next-line drop/no-prisma-delete |
Member
There was a problem hiding this comment.
This should have a // SAFETY comment describing why the lint was turned off.
| message: "Group name already exists", | ||
| }); | ||
|
|
||
| // eslint-disable-next-line drop/no-prisma-delete |
| if (!group) | ||
| throw createError({ statusCode: 404, message: "Group not found" }); | ||
|
|
||
| // eslint-disable-next-line drop/no-prisma-delete |
| }, | ||
| }); | ||
|
|
||
| return await prisma.userGroup.findUnique({ |
Member
There was a problem hiding this comment.
Nitpick: it's kinda messy to return directly like, maybe assign it to a variable first and then return that?
| }), | ||
| ]); | ||
|
|
||
| return await prisma.bannedAgeRating.findMany({ |
Member
There was a problem hiding this comment.
Same direct return nitpick as above.
| if (oidcGroups === undefined) return; | ||
|
|
||
| if (oidcGroups.length === 0) { | ||
| // eslint-disable-next-line drop/no-prisma-delete |
| select: { id: true }, | ||
| }); | ||
|
|
||
| // eslint-disable-next-line drop/no-prisma-delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "Groups" as a concept to drop, with the ability to ban certain age ratings from those groups.
This completes the server side for #236 , will need to test the clients.
Flow goes in two ways:
Both give the ability to ban age ratings from groups if desired, so an admin can create a "kids" group and from there select "ESRB AO" and "ESRB M" ratings which will no longer show up for kids.