Skip to content

HtmlFieldWithConverter does not select correct element #55

Description

@cr3ativ3

ElementConverter.class's javadoc states that @param node The matched {@code element} but it is not true. HtmlFieldWithConverter does not perform css selection before passing element to convert() method so the node element is actually the whole HTML document.

And even the custom convert test is faulty, you can change

"<p id=\"today-weather\">Today is Saturday. Weather is sunny</p>"

to:
"<p id=\"kdjkfajjdfhb-it-doesnt-matter\">Today is Saturday. Weather is sunny</p>" and the test will still pass successfully.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions