Skip to content

ci: remove broken Issues workflow and script - #1871

Merged
joshunrau merged 1 commit into
DouglasNeuroInformatics:mainfrom
dyk1454683243-sudo:fix/1786-remove-issues-workflow
Nov 5, 2026
Merged

joshunrau merged 1 commit into
DouglasNeuroInformatics:mainfrom
dyk1454683243-sudo:fix/1786-remove-issues-workflow

Conversation

@dyk1454683243-sudo

Copy link
Copy Markdown
Contributor

Fixes #1786

The Issues workflow fails on every issue that is opened or reopened. .github/workflows/issues.yaml calls require('./.github/scripts/issues.cjs')() with no arguments, and the script immediately destructures { context, github }. That throws TypeError: Cannot destructure property 'context' of 'undefined' before any API call, which is why every retained run of the workflow is red.

Passing { context, github } would turn the run green and then do the wrong thing. The script reads Priority and Estimated Difficulty out of the issue body and adds those labels, and it prefixes the title with [Kind]: (again on each reopen). The maintainer recommendation on #1786 is to delete both files and not reimplement the label or title step: triage replaces the reporter's Difficulty estimate most of the time, so an add-only step leaves two Difficulty labels, and the title prefix contradicts the documented title convention.

This deletes .github/workflows/issues.yaml and .github/scripts/issues.cjs only.

knip.ts still ignores github-script because .github/scripts/release.cjs types its arguments with import('github-script'). That entry stays. Open PR #1822 drops that JSDoc from release.cjs; whichever change lands second should remove the unused github-script ignore (and its comment) so pnpm knip stays clean.

Verified by confirming both files are gone, that nothing else references issues.cjs or the Issues workflow, and that release.cjs still references github-script. No unit or Playwright test runs a GitHub workflow, and .github/scripts is outside the coverage include.

The Issues workflow calls issues.cjs with no arguments, so every opened
or reopened issue fails while destructuring context and github. Delete
the workflow and script instead of passing those arguments: the label
step adds Difficulty labels that contradict triage, and the title prefix
contradicts the documented title convention.

Co-Authored-By: Grok 4.7
Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
@joshunrau
joshunrau merged commit 8acc9a7 into DouglasNeuroInformatics:main Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues workflow fails on every opened issue because issues.cjs is called without its arguments

3 participants