Repository navigation
feat: add instance-wide card themes for light and dark mode - #1868
Draft
thomasbeaudry wants to merge 1 commit into
Draft
thomasbeaudry wants to merge 1 commit into
thomasbeaudry wants to merge 1 commit into
Conversation
Put in-app pages on a card an administrator can color per mode from the application settings, and shrink page submit buttons that read as bars once the card around them is invisible. Co-Authored-By: Claude Opus 5.5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Every in-app page now sits on an
InstanceCard, which draws nothing by default. Admins can color these cards from Application Settings, with a separate choice for light and dark mode:The picker reuses the login branding page's swatches. This adds
lightCardTheme,darkCardTheme,customCardColorLightandcustomCardColorDarkto the setup state.Page submit buttons are now compact, because a full-width button reads as a bar once the card around it is invisible. Forms in dialogs and sheets keep the full width.
The dashboard takes no instance color, and start session keeps the page color inside a thin card. Login, password reset, setup, the form render page and the gateway are unchanged.
apps/web/AGENTS.mddocuments the rules.Verification
pnpm lintpasses.card-color,InstanceCard,Layout, the settings page, the setup schema and the setup service. The only failure is theWalkthroughProvidertest that already fails onmain(Unit suite fails on main: walkthrough test queries the pre-rename button label #1865). That failure also failspnpm test:coverage; the only uncovered lines are that button's click handler.testing/src/specs/instance-card-color.spec.ts, plus updates toadmin-instrument-repos.spec.tsand the settings page object.Before merging
pnpm test:e2e. Only the affected specs have run, on a stack without a gateway, so the two/abouttests failed there. One earlier run also had failures on/admin/settingsand/datahub/instrumentsthat did not recur in two reruns of the spec, and the cause was not found./session/remote-assignmentand the/group/*, datahub detail and/uploadpages have no card color e2e coverage.mainhad changed it tomax-w-4xl.Co-Authored-By: Claude Opus 5.5