Repository navigation
Conversation
The legend's series names repeated the tooltip's inline "Records" and "Sessions" translations, so the two could drift apart. Both now read from one recordsLabel and one sessionsLabel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1782. Supersedes #1819.
The dashboard's Records & Sessions Trend chart told its two series apart only by colour and the hover tooltip (WCAG 1.4.1).
<Legend />so both series are labelled without hovering.Areaa translatedname(en/es/fr), so the legend reads in the interface language.legendType="plainline", so the line and its legend icon differ by more than colour.The first commit is @misaelalves99's work from #1819, kept with their authorship. The second commit applies the review feedback that PR never picked up.
Verification
apps/web/src/routes/_app/__tests__/dashboard.test.tsx(34/34) checks that the legend appears only on the trend chart, the series names in all three languages, and that only sessions is dashed.testing/src/specs/dashboard.spec.tschecks that the legend is visible with both labels and that only the sessions icon is dashed.pnpm --filter @opendatacapture/web lintpasses. The fullpnpm lint,test:coverageandtest:e2ewere not run locally; CI runs them.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com