Repository navigation
build: bump dev and docs tooling for security advisories - #1856
Merged
Merged
Conversation
Bump the build, docs and Storybook tooling that has Dependabot security alerts to patched versions: - storybook and @storybook/* 10.6.4 (GHSA-px85-f4q5-jh77, GHSA-f2ph-cmg5-wxc8) - sharp 0.35.5 for outreach; astro 5 lists sharp ^0.34 as an optional dependency, so a sharp override keeps one patched copy - vite 6.4.5, svgo 4.1.0, devalue 5.9.4 and smol-toml 1.9.0 under astro 5 - markdown-it 14.3.3 (typedoc) - postcss-selector-parser 6.1.5; @tailwindcss/typography pins 6.0.10 exactly, so this needs a scoped override - browserslist 4.29.5 and baseline-browser-mapping 2.11.33 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W53iUSpZekM2didbKGCSSv
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Intermittent graph-tab e2e failures on this branch, absent in isolated main runs, require clean-environment CI validation to distinguish a dependency regression from timing flakiness.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Updates Open Data Capture’s development, documentation, and Storybook dependencies to address security advisories without changing application source code.
Changes:
- Updates Storybook packages to locked version 10.6.4.
- Upgrades Sharp to 0.35.5, including Astro’s optional dependency through a root override.
- Refreshes affected transitive tooling dependencies and overrides Tailwind Typography’s selector parser.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Raises shared Storybook version ranges to ^10.6.3. |
pnpm-lock.yaml |
Locks updated tooling versions and their dependency trees. |
package.json |
Adds Sharp and selector-parser overrides. |
apps/outreach/package.json |
Raises outreach’s direct Sharp dependency to ^0.35.5. |
Review effort: Balanced
joshunrau
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump dev, docs and Storybook tooling that has Dependabot security alerts. No source changes.
storybook,@storybook/*sharpvite(6.x)svgodevaluesmol-tomlmarkdown-itpostcss-selector-parser(6.x)browserslist/baseline-browser-mappingNew overrides in root
package.json:sharp: ^0.35.5. astro 5 listssharp@^0.34.0as an optional dependency and imports its own copy for the image service, so bumping outreach alone leaves a vulnerable copy in use.astro buildof outreach passes with sharp 0.35.5 (images are optimized).@tailwindcss/typography>postcss-selector-parser: ^6.1.5. typography 0.5.20 (latest) pins 6.0.10 exactly.Not in this PR
The astro alerts themselves (fix only in astro 7) are dismissed as tolerable risk: outreach is
output: 'static'and built from repo-owned content.Verification
pnpm --filter @opendatacapture/outreach build: passes.pnpm lintandpnpm test:coverage(100%) pass.pnpm test:e2e: 346 passed, 2 failed.record-file-deletion.spec.tsalso fails onmainlocally because my.envhasSTORAGE_ENABLED=false. It is an environment exception.subject-detail.spec.ts:53(graph tab) timed out in the full run and 1 of 4 isolated runs (the Measures button stayed disabled). main passed 4/4 isolated. This PR changes no web runtime code, so I think it is flaky timing, but CI must confirm.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com