Repository navigation
Simplify project creation flow - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the unresolved import-cancellation and source-validation issues, and expand the cancellation test coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Simplifies project creation by consolidating source selection, replacement, validation, persistence handling, and related UI updates.
Changes:
- Reworked PDF, photo, and text source creation flows.
- Added draft validation, import lifecycle handling, and persistence error handling.
- Updated text editing, tests, and localization.
| File | Summary |
|---|---|
LoopLineTests/ProjectPersistenceTests.swift |
Adds persistence coverage. Nit (1 vote): test should exercise the actual cancel path. |
LoopLine/Views/ProjectListView.swift |
Updates creation UI. Moderate (1 vote): disable or cancel actions during image imports. |
LoopLine/Views/ProjectDetailView.swift |
Updates pattern text editing UI. |
LoopLine/ViewModels/ProjectListViewModel.swift |
Adds throwing persistence and rollback handling. |
LoopLine/ViewModels/CreateProjectViewModel.swift |
Manages sources and saving. Moderate (1 vote): invalidate pending imports on source changes. Moderate (3 votes): restore per-source validation for usable content and file paths. |
Localizable.xcstrings |
Updates localization strings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| case .image: | ||
| imageFilePath != nil | ||
| } | ||
| !trimmedName.isEmpty && sourceType != nil |
DominikMoreira
force-pushed
the
improve-project-onboarding
branch
from
September 27, 2026 06:20
abe9d36 to
f80c47f
Compare
DominikMoreira
force-pushed
the
improve-project-onboarding
branch
from
September 27, 2026 20:11
f80c47f to
43a8d28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.