fixed generate_api_token#6
Open
mhdalik wants to merge 3 commits into
Open
Conversation
docket-go
requested changes
Feb 17, 2023
docket-go
left a comment
docket-go
left a comment
Contributor
There was a problem hiding this comment.
Use SQLAlchemy for SQLite3, Never call the commands directly, It will lead to SQLInjection
Contributor
|
Base.metadata.create_all(engine) This is breaking in my system @edwinsjohn @Eldhosee Could you check ? |
edwinsjohn
reviewed
Feb 22, 2023
edwinsjohn
left a comment
edwinsjohn
left a comment
Contributor
There was a problem hiding this comment.
@docket-go I tried running it, No problem with Base.metadata.create_all(engine). But when i tried calling generate_token function there were some problems with session.query(self). Can be solved by adding a nested class / By taking both functions out of ApiToken class and putting them into another class .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.