fix(auth): add auth dialog window icon - #514
Open
thesageak wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Slice
What this PR does
Adds the Doberman mark as the auth dialog window icon using Tk's
iconphoto()API.The icon uses the existing bundled
doberman-mark.pngasset and keeps a reference on the root window so Tk does not drop the image. Icon setup is best-effort and will not prevent the auth dialog from opening if loading or setting the icon fails.Tests added (run in CI)
_configure_window()callsiconphoto()once with the default flag enabled.tests/unit/test_gui_prompter.py: 37 passed locally.Public-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
iconphoto()behavior is covered by the faked-root unit test.Closes #432