fix(dash): confirm copied approval details - #506
Open
lKolabrodl wants to merge 1 commit into
Open
Conversation
lKolabrodl
force-pushed
the
fix/dash/copied-feedback
branch
from
August 30, 2026 00:10
703221e to
99e8898
Compare
lKolabrodl
marked this pull request as ready for review
September 1, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Slice
What this PR does
After a pending card's redacted JSON is written to the clipboard, the copy button now displays
Copied!for 1.5 seconds and then restoresCopy details. Repeated successful copies restart the timer, while clipboard failures leave the button text unchanged.The existing dashboard polish regression test now verifies the success text and timeout without changing the copied JSON fields. The README describes the visible confirmation.
Closes #503
Tests added (run in CI)
tests/unit/test_dash_polish.py::test_pending_card_can_copy_only_redacted_detailsto cover the transient success label and 1.5-second reset.pytest tests/unit/test_dash_polish.py -q— 18 passed.doberman(test_real_plugin_install_discovery.py). The same test was rerun alone and reproduced the environment-onlyModuleNotFoundError.ruff check .andruff format --check .lint-importspython scripts/check_markdown_links.pypython -m tools.parity.generate_parity --checkPublic-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
AI assistance
This change was implemented with AI assistance and manually reviewed. All commands and verification results above were run locally.