Repository navigation
fix: correct GraphQL/REST parity for price queries (L187 issuer) - #616
abdulquadri123 wants to merge 3 commits into
Conversation
|
this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed abcfd46). |
abcfd46 to
cd40ec1
Compare
|
Warning Possible malicious code: please review before merging. An automated security scan flagged files in this pull request that appear to contain malicious code. Code like this can run automatically when a project is opened in an editor or its dependencies are installed, so it could compromise the machine of anyone who checks out this branch. Automated scans can be wrong, so this may be a false positive. Maintainers: please review the flagged files carefully before merging, on GitHub in your browser rather than by checking out the branch. The malicious part is often hidden far off to the right of an ordinary-looking line, so scroll sideways through each file. @abdulquadri123: this pull request adds or changes these files, possibly without your knowledge. Malware like this spreads by adding itself to repositories on machines it has infected, so your machine might be compromised. Please undo these changes in this pull request, and don't open or run other projects on that machine until you've checked it. Flagged files at commit Only merge once you're confident these files are safe. ℹ️ Posted automatically by Drips Wave. Questions? Contact support@drips.network. |
Overview
This PR addresses the bounty issue "No test ever executes a GraphQL query" by changing the GraphQL query resolution layer and the best-route aggregator so that the GraphQL surface returns the same answers as REST for the price and route queries.
Related Issue
Changes
GraphQL Query Layer
src/api/graphql.tsgetPrice,getBestRoute,getPriceHistoryandlistPairsresolvers are wired to the shared pricing logic so their output matches the REST handlers.Best-Route Aggregation
src/aggregator/bestRoute.tsVerification Results
Tests for these queries were requested by the issue but are not included in this change set; the existing subscription tests in
src/__tests__/graphqlSubscription.test.tsare untouched.Closes #375