Skip to content

Fix Slides de-render crashes and add Docs/Slides regression CI - #70

Merged
Divide-By-0 merged 2 commits into
masterfrom
codex/docs-slides-regression-ci
Sep 15, 2026
Merged

Divide-By-0 merged 2 commits into
masterfrom
codex/docs-slides-regression-ci

Conversation

@Divide-By-0

@Divide-By-0 Divide-By-0 commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Fix a Slides de-render crash caused by reading Common.DerenderResult at runtime, and stop replacing unrelated server exceptions with “please select image.” Both De-render All and De-render Selection now use local status constants that preserve the sidebar's existing numeric protocol.

Human intent

  • Fix Slides equations that render but cannot be de-rendered, with either button reporting a selection error regardless of selection; Docs reportedly works.
  • Reproduce first, confirm the cause with a debugger, make a surgical fix, and add regression tests and CI for Docs/Slides. Preserve this process as a reusable skill.

Cause and change

A read-only download of the Slides project HEAD contains runtime Common.DerenderResult accesses. Its pinned Common v8 has no enum object: the const enum was erased during compilation. Isolated Slides transpilation leaves those property accesses intact. A full-program build can inline them, which explains why merely running that build can hide the regression.

Add a local Slides enum with explicit values matching the sidebar's type declarations. No Common library update is required. Sidebar failure handlers now display escaped server error details and restore the buttons/loading state. The existing test/CI work also fixes the Workspace harness's dependency on an ignored build output and adds Slides delimiter coverage.

Evidence and validation

  • Unchanged remote HEAD + Common v8: both public actions fail locally with TypeError reading Success / InvalidUrl.
  • Debugger breakpoint in editEquations: selectionType=PAGE_ELEMENT, one selected image, and Common.DerenderResult=undefined.
  • Source-based reproduction fails before the patch and passes after it. Old sidebar tests reproduce both reported “please select” messages.
  • All 43 local tests pass. New cases cover both actions, multiple equations mixed with ordinary images, legacy metadata, selection statuses, and escaped RPC errors.
  • Slides sidebar build passes and is included in GitHub Actions alongside the complete suite.
  • The personal reproduce-debug-regress skill was installed and validated during this task.

Limits and release

The older Slides v7 deployment inlines these constants correctly. The reporter's installed version and affected presentation have not been identified, so the verified defect in project HEAD is not proof of the exact deployed failure they encountered. Tests execute real downloaded/compiled code with local Apps Script doubles, not a live Google Slides session.

No Apps Script push, release, merge, or Marketplace update was performed. The original checkout's unrelated uncommitted work is untouched. Tracking: AGENTS-109.

@Divide-By-0 Divide-By-0 changed the title Run Docs and Slides regressions in CI from a clean checkout Fix Slides de-render crashes and add Docs/Slides regression CI Sep 15, 2026
@Divide-By-0
Divide-By-0 merged commit f1569bc into master Sep 15, 2026
2 checks passed
@Divide-By-0
Divide-By-0 deleted the codex/docs-slides-regression-ci branch September 15, 2026 22:11
@Divide-By-0

Copy link
Copy Markdown
Owner Author

Live Slides verification after merge

Tested merged commit f1569bc00e2bd66e3d8bb86286cb0379c11e314d in the existing “Auto-LaTeX Equations Slides Dev Test Correct” sandbox, using its bound Auto-LaTeX Equations: Slides → Start menu. Compiled server code and rebuilt the sidebar, pushed only the sandbox, then clasp pull verified Code.js and SidebarJS.html byte-for-byte. Common is pinned to v8, development mode off.

Case Live result
One selected equation image 1 equation de-rendered; LaTeX restored
Multiple equation images mixed with text/shapes (13 objects selected) 8 equations de-rendered; other objects retained
De-render All with the slide selected, no image selected 43 equations de-rendered across the presentation

Screenshots below are paired before/after. The existing sandbox contains legacy layouts and narrow image bounds, so restored source sometimes wraps tightly; this test verifies de-rendering and status reporting, not layout changes.

Single image — before / after

slides-single-before slides-single-after

Multiple images with other objects — before / after

slides-multi-before slides-multi-after

De-render All, no image selection — before / after

slides-all-before slides-all-after

Alt-text follow-up: #69 is still open and changes Docs only. Its exact head 6b47b8d0684f73d1bb1be67ac06a7337aa7f883a was pushed to a separate new Docs sandbox and pulled back successfully, but Google blocked first-run authorization (“This app is blocked”). No live alt-text results are claimed; an existing authorized Docs test document is needed to finish those cases.

No production Apps Script project or Marketplace release was updated. Marketplace preparation is pending the requested screenshot approval.

@Divide-By-0

Copy link
Copy Markdown
Owner Author

Published to Marketplace after user screenshot approval.

  • Slides v15, immutable source verified against merged f1569bc00e2bd66e3d8bb86286cb0379c11e314d; Common v8, development mode off.
  • Existing listing 850293439076 keeps Slides script 19JXrVleOChdQi_hwaDnhWiz9YIK8ulheIzFHa-fy-doeWbhcyhdBM5JF, updated from v14 to v15. Saved the draft, clicked Publish, received Updates published, then reloaded App Configuration and verified v15 persisted.
  • Docs Marketplace version remains v95. No OAuth scopes or listing content were changed.
  • Additional root-cause confirmation: the listing’s prior Slides v14 contains the broken Common.DerenderResult references. Its server source differs from the tested release only at the corrected enum references; the sidebar diff contains the new real-error reporting.
marketplace-updates-published marketplace-slides-v15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant