Every worker copies the whole ifc file into memory

docker-compose.yml

@@ -11,4 +11,5 @@ services:
       - ./:/app
       - /tmp/.X11-unix:/tmp/.X11-unix:ro
       - ${XAUTHORITY:-$HOME/.Xauthority}:/tmp/.Xauthority:ro
+      - ~/maps:/app/data:rw
     # Inherit CMD from Dockerfile: python3 -m pointcloud_tools.gui

pointcloud_tools/gui.py

@@ -484,7 +484,7 @@ def build_ifc(self):
         self.ifc_path = tk.StringVar()
         ctk.CTkLabel(f, textvariable=self.ifc_path).grid(row=2, column=1, sticky="w")
 
-        ctk.CTkLabel(f, text="Processes (blank=auto)").grid(row=3, column=0, sticky='w')
+        ctk.CTkLabel(f, text="IFC workers (blank=auto)").grid(row=3, column=0, sticky='w')
         self.ifc_proc = tk.StringVar()
         ctk.CTkEntry(f, textvariable=self.ifc_proc, width=120).grid(row=3, column=1, sticky='w')
 
@@ -512,7 +512,11 @@ def do_ifc_convert(self):
         if not mesh_out:
             return
         self.cfg["local_initialdir"] = os.path.dirname(mesh_out)
-        proc = int(self.ifc_proc.get()) if self.ifc_proc.get().strip() else None
+        try:
+            proc = int(self.ifc_proc.get()) if self.ifc_proc.get().strip() else None
+        except ValueError:
+            messagebox.showerror("Error", "IFC workers must be a whole number")
+            return
 
         types = list_element_types(infile)
 
@@ -521,28 +525,40 @@ def do_ifc_convert(self):
         vars = {}
         for i, t in enumerate(sorted(types.keys())):
             var = tk.BooleanVar(value=True)
-            tk.Checkbutton(sel, text=t, variable=var).grid(row=i, column=0, sticky="w")
+            tk.Checkbutton(sel, text=f"{t} ({types[t]})", variable=var).grid(
+                row=i, column=0, sticky="w"
+            )
             vars[t] = var
         def on_ok():
             sel.include = [t for t, v in vars.items() if v.get()]
             sel.destroy()
         tk.Button(sel, text="OK", command=on_ok).grid(row=len(vars), column=0)
         sel.wait_window()
-        include = getattr(sel, 'include', None)
+        if not hasattr(sel, 'include'):
+            return
+        include = sel.include
+        if not include:
+            messagebox.showerror("Error", "No IFC element types selected")
+            return
+
+        if not confirm_overwrite_gui(mesh_out):
+            return
 
         self.log_text.delete("1.0", tk.END)
 
         def worker():
             try:
                 with contextlib.redirect_stdout(self.stdout_redirector):
-                    ifc_to_mesh(
+                    mesh = ifc_to_mesh(
                         infile,
                         mesh_out,
                         show_result=self.ifc_show.get(),
                         num_processes=proc,
                         include_types=include,
-                        confirm_func=confirm_overwrite_gui,
+                        confirm_func=lambda _: True,
                     )
+                    if mesh is None:
+                        raise RuntimeError("IFC conversion did not produce a mesh")
                 def done():
                     self.add_recent_file(mesh_out)
                     messagebox.showinfo("Done", "Mesh generated")
@@ -832,17 +848,35 @@ def task(prev):
                 vars = {}
                 for i, t in enumerate(sorted(types.keys())):
                     var = tk.BooleanVar(value=True)
-                    tk.Checkbutton(sel, text=t, variable=var).grid(row=i, column=0, sticky="w")
+                    tk.Checkbutton(sel, text=f"{t} ({types[t]})", variable=var).grid(
+                        row=i, column=0, sticky="w"
+                    )
                     vars[t] = var
                 def on_ok():
                     sel.include = [t for t, v in vars.items() if v.get()]
                     sel.destroy()
                 tk.Button(sel, text="OK", command=on_ok).grid(row=len(vars), column=0)
                 sel.wait_window()
-                include = getattr(sel, 'include', None)
+                if not hasattr(sel, 'include'):
+                    return
+                include = sel.include
+                if not include:
+                    messagebox.showerror("Error", "No IFC element types selected")
+                    return
+
+                if not confirm_overwrite_gui(out):
+                    return
 
                 def task(prev):
-                    ifc_to_mesh(ifc, out, show_result=False, include_types=include, confirm_func=confirm_overwrite_gui)
+                    mesh = ifc_to_mesh(
+                        ifc,
+                        out,
+                        show_result=False,
+                        include_types=include,
+                        confirm_func=lambda _: True,
+                    )
+                    if mesh is None:
+                        raise RuntimeError("IFC conversion did not produce a mesh")
                     return out
                 desc = f"IFC->Mesh {os.path.basename(ifc)}"
             elif op == "Downsample PCD":