RS-21744: move desktopq snapshot test here - #60
Open
SurreyHughesDisplayr wants to merge 3 commits into
Open
Conversation
SurreyHughesDisplayr
requested review from
chschan
and
a balanced review from Copilot
August 4, 2026 07:02
There was a problem hiding this comment.
Pull request overview
Adds Desktop Q’s visual regression case to this repository and updates local snapshot execution.
Changes:
- Adds the snapshot fixture and definition.
- Introduces a cross-platform local test launcher.
- Routes
npm run localTestthrough the launcher.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
xx.yaml |
Defines the visual regression case. |
xx.json |
Provides its node and label data. |
package.json |
Uses the new local test launcher. |
bin/localTest.js |
Resolves the branch and invokes gulp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+10
| type: single_page_one_example_per_config | ||
| comments: [] | ||
| data: data.functional_tests.xx | ||
| config: | ||
| - '{}' |
Contributor
|
Can we name the new snapshot something more informative than xx.png? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop Q runs snapshot tests. I move the desktop q one to this repo so it will run on changes rather than waiting for overnight tests.