Untracked: updated to use the new buildutil - #59
Open
SurreyHughesDisplayr wants to merge 12 commits into
Open
Conversation
with_title.json and without_title.json hold only title/subtitle/footer
settings - they are config fragments, not datasets. Sitting in
data/real_data meant the real_data_tests_{500,750,1000} plans, which are
type: for_each_data_in_directory, globbed them and rendered each as a
standalone dataset. Neither has coreNodes, so the widget threw
"Invalid config. Missing coreNodes" and assertNoLogError failed 6 tests.
The committed baselines were pictures of the resulting empty widget, so
the image assertions passed and masked it.
Moved both to internal_www/config/ alongside title_enabled.json etc,
where they are usable via the | merge syntax, and dropped the 6 stale
baselines. Title rendering stays covered by
functional_tests/title_subtitle_footer.yaml.
Full visual suite: 51 passed, 86 snapshots passed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rhtmlBuildUtil now uses ESBuild. This PR updates to use that and the associated d3 update. This changed snapshots slightly.