Conversation
Accepting or deleting a relation schema re-rendered TldrawCanvasShared. In local sync mode that rebuilds the store adapter args, so useRoamStore made a new store from the page-load snapshot and the next edit saved it over the page. The canvas now only listens for schema changes to leave a deleted relation tool, the tool panel refreshes its own list, and isAcceptedRelationSchema reads acceptance live instead of from a canvas-owned cache.
Entire-Checkpoint: 01M327E9K9BPPZ1R8T0PTZ1KX7
Hide already imported nodes and drop the source app, source ID, and status columns. Sort by source space, title, or modified, newest first by default. Rename the dialog and command to Import shared nodes, give the dialog a fixed height, and show import progress and the result in one area that links each imported node by its Roam title.
Set the node results and failed-node selection before the relations import, so a relations failure no longer leaves hidden rows selected without a result list. Stop searching the source app and source ID, which the table no longer shows.
Report a relations failure after a successful node import as its own message, so it no longer reads as a node import failure next to a success summary. Let the dialog body scroll when a short window can't fit the search, result, and table.
Imported node titles arriving from Roam carry page references and tags ([[EVD]] - x - [[@smith 2020]]), and the import path only stripped the OS file-name set, so the brackets reached the note's file name. Obsidian creates such a file but cannot link to it, so the node imports and then sits disconnected from the rest of the graph. Unwrap page references and drop the characters Obsidian rejects in file names (the set checkInvalidChars already enforces when a user creates a node), in a function of its own with tests. Asset paths keep the narrower rule. A title that sanitizes to nothing falls back to the node instance id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BmGT261gNCnNMmW8h6HXbn
…ted-relation-types-and-triples-in' into push-pull-validation-head
…ema-metadata-between-sync-and-publish' into push-pull-validation-head
…py-by-bumping-the-roam-nodes-edit' into push-pull-validation-head
…t-dialog-and-import-feedback' into push-pull-validation-head
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/26
Do not merge. This PR exists only so the team can check out the push/pull validation candidate and test the same code. It adds no code of its own.
Reviewer brief
push-pull-validation-headatb3796a70is main4a13294awith five open PRs merged in, one merge commit each: ENG-2131 Review and accept imported relation types and triples in Roam #1383 (ENG-2131), ENG-2202 Reconcile Roam node schema metadata between sync and publish #1475 (ENG-2202), ENG-2288 Retry a failed asset copy by bumping the Roam node's edit time #1477 (ENG-2288), ENG-2296 Simplify the Roam import dialog and import feedback #1479 (ENG-2296) and Derive Obsidian import file names from titles Obsidian can create #1482 (Obsidian import file names). Each PR's current head is the commit merged here.git fetch origin && git checkout push-pull-validation-head, then build the Roam extension and the Obsidian plugin from it. The test cases and the failures found so far are on the validation matrix page shared in the team meeting notes.Verification
pnpm ci:validatepassed onb3796a70: 8/8 check-types and all unit suites.Loom video
Not applicable: no code change to show.
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: not applicable. The diff is the five PRs above, each reviewed in its own PR.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Not run: this PR is not for review or merge.
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.Not run, for the same reason.