Skip to content

ENG-2292 Remove the duplicate title from Roam-origin nodes imported into Obsidian - #1470

Merged
maparent merged 1 commit into
mainfrom
eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported
Sep 22, 2026
Merged

maparent merged 1 commit into
mainfrom
eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported

Conversation

@maparent

@maparent maparent commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/5

(This is empty, may be an issue with my entire setup?)

Reviewer brief

Following the strategy discussed in linear.

Verification

See loom.

Loom video

https://www.loom.com/share/121491b7c3cb4f89bc71237eb270ae6c

Scope check

  • Ran $scope-check against ENG-2292 and the final diff.
  • Scope beyond Done When: The fix lands on the Roam publisher and the shared contract rather than on the Obsidian import path. buildFullMarkdown stops prepending # <title> and loses its title parameter, stripTitleHeading is deleted from @repo/content-model with its tests, Roam's own fetchFullMarkdown re-keys the preamble strip on content type instead of platform, and packages/database/schema.yaml documents the full variant. Obsidian's row pairing was extracted to resolveImportedNodeContent with unit tests, where an empty full body is now valid.
  • Required now: ENG-2292 itself. Both importers read the title from direct, so removing it from full at the source is what satisfies the criteria; the read-time stripper was the rejected alternative. Accepting an empty full is a hard prerequisite — a title-only Roam page now publishes an empty body, which the old !full?.text guard silently dropped.
  • Anyone affected or consulted: Yes — Michael Gartner approved the contract change in the ticket.
  • Decision: https://linear.app/discourse-graphs/issue/ENG-2292 (comment thread, 2026-09-19) and the memo at https://roamresearch.com/#/app/discourse-graphs/page/2Uf8JO1d7

Worth knowing:

  • Done When Releases storage url rewrite #3 is not fully met by this diff. The seven Roam-origin full rows already in the database still carry the title, so a re-import restores it until they are deleted and resynced. The deletion must happen after the Roam publisher ships, or older clients refill them in the old format.

Local delegated full review

  • Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

https://linear.app/discourse-graphs/issue/ENG-2292/remove-the-duplicate-title-from-roam-origin-nodes-imported-into


Devin Review

@vercel

vercel Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
discourse-graph Ready Ready Preview Sep 22, 2026 1:07pm UTC

Request Review

@linear-code

linear-code Bot commented Sep 20, 2026

Copy link
Copy Markdown

ENG-2292

@supabase

supabase Bot commented Sep 20, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread apps/obsidian/src/utils/importedNodeContent.ts
@maparent
maparent force-pushed the eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported branch from 7209536 to c122847 Compare September 22, 2026 13:06
@maparent
maparent merged commit 15808bf into main Sep 22, 2026
14 checks passed
@maparent
maparent deleted the eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported branch September 22, 2026 13:10

This branch was successfully deployed

1 active deployment
Preview — c122847e Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants