ENG-2292 Remove the duplicate title from Roam-origin nodes imported into Obsidian - #1470
Merged
maparent merged 1 commit intoSep 22, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported
branch
from
September 21, 2026 16:27
da2e0a5 to
7209536
Compare
mdroidian
approved these changes
Sep 22, 2026
maparent
force-pushed
the
eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported
branch
from
September 22, 2026 13:06
7209536 to
c122847
Compare
maparent
deleted the
eng-2292-remove-the-duplicate-title-from-roam-origin-nodes-imported
branch
September 22, 2026 13:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/5
(This is empty, may be an issue with my entire setup?)
Reviewer brief
Following the strategy discussed in linear.
Verification
See loom.
Loom video
https://www.loom.com/share/121491b7c3cb4f89bc71237eb270ae6c
Scope check
$scope-checkagainst ENG-2292 and the final diff.Done When: The fix lands on the Roam publisher and the shared contract rather than on the Obsidian import path.buildFullMarkdownstops prepending# <title>and loses itstitleparameter,stripTitleHeadingis deleted from@repo/content-modelwith its tests, Roam's ownfetchFullMarkdownre-keys the preamble strip on content type instead of platform, andpackages/database/schema.yamldocuments thefullvariant. Obsidian's row pairing was extracted toresolveImportedNodeContentwith unit tests, where an emptyfullbody is now valid.direct, so removing it fromfullat the source is what satisfies the criteria; the read-time stripper was the rejected alternative. Accepting an emptyfullis a hard prerequisite — a title-only Roam page now publishes an empty body, which the old!full?.textguard silently dropped.Worth knowing:
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2292/remove-the-duplicate-title-from-roam-origin-nodes-imported-into