ENG-2280 Run the asset stage when the sync re-uploads a shared node's content

[maparent]

Reviewer brief

A lot of changes were a factoring out of now common code into src/utils/__tests__/fixtures/fileReferenceHarness.ts

Verification

Unit tests, plus loom.

Loom video

In progress.

Scope check

• Ran $scope-check against ENG-2280 and the final diff.
• Scope beyond Done When: None. The implementation reaches the Done When criteria by a different route than the ticket's Solution proposed: convertRoamNodeToFullContent returns the CrossAppNode it already builds, rather than widening RoamDiscourseNodeData. The node sync path and RoamDiscourseNodeData are unchanged, so the Out of Scope line on converting the sync to CrossAppNode still holds.

Local delegated full review

• Ran a comprehensive review of the entire final diff in a subagent with a fresh context.

Two problems sit outside this ticket and belong to future ticket(s), not yet filed:

• Nodes shared before the asset stage existed never ran it.
• A node whose individual asset copy fails during an otherwise successful sync is never revisited, because re-processing keys on the node's Roam edit time and on a missing Content row, never on FileReference.

Both look the same from the database, an asset referenced in the published markdown with no FileReference row, so one query finds and repairs both. Anything narrower built here would be replaced by that query.

Findings:

• Failed copies are not retried. Deferred to the ticket above. The PostHog counts are the standing signal until it lands.
• Bound the asset transfer per run, since SYNC_TIMEOUT is 60s. Also deferred, because a budget without the retry defers exactly the assets nothing comes back for. Overrunning the claim costs a re-claim and a reprocessed window, and each pass keeps the references it already wrote, so passes converge.
• The sync test mocks roamToCrossAppConverters wholesale. The FK ordering test is added: a failed content upload writes no FileReference row. The mock stays, because unstubbing it needs a fake Roam graph for getFullTreeByParentUid and getPageViewType, and roamToCrossAppConverters.test.ts covers that conversion directly. End-to-end coverage of the sync path is its own ticket.

https://linear.app/discourse-graphs/issue/ENG-2280/run-the-asset-stage-when-the-sync-re-uploads-a-shared-nodes-content

---

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
discourse-graph	Skipped		Sep 19, 2026 1:47pm UTC

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[linear-code]

ENG-2280

[devin-ai-integration]

Devin Review found 2 potential issues.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)