ENG-2188 Node type settings are spread across seven inner tabs; put them on one page - #1420
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
Contributor
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
trangdoan982
force-pushed
the
eng-2188-node-type-settings-are-spread-across-seven-inner-tabs-put
branch
from
September 8, 2026 21:22
64d614b to
d59d299
Compare
…hem on one page A node type's settings become one vertical page: Identity (Index first, then Description, Tag, Color, Format), Creation, Canvas, Legacy (Specification), the sync-gated Suggestive mode, and Attributes last. Index and Template are drill-down rows on the ENG-2186 primitive, each with its own sub-page. Specification's toggle reads "Enabled" (its lowercase block text stays the storage key via blockKey) and the query builder renders only while it is on. Format loses its DEPRECATED note: Specification is the one in migration. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
trangdoan982
force-pushed
the
eng-2188-node-type-settings-are-spread-across-seven-inner-tabs-put
branch
from
September 8, 2026 21:54
d59d299 to
72e962e
Compare
2 tasks
trangdoan982
removed this pull request from stack #1423
September 9, 2026 19:16
trangdoan982
added this pull request to stack #1426
September 9, 2026 19:30
mdroidian
reviewed
Sep 11, 2026
| cursor: pointer; | ||
| } | ||
|
|
||
| .dg-settings-node-page { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer brief
Grammar › Nodes › <node> › Indexbreadcrumb.NodeConfig.tsxis a re-layout. No setting changes its key, default, or write path. The newSettingsDrillDownRowrenders a row that pushes a segment on the ENG-2186 route;NodeIndexPageandNodeTemplatePagewrap the existing panels for the two sub-pages.Enabled. Its block text stays lowercaseenabledthroughblockKey, so storage is unchanged. The query builder renders only while the toggle is on.Legacygroup for settings mid-migration, and Attributes moved last. Format'sDEPRECATED — use Specificationnote was removed with it, since Specification is now the setting in flux.Verification
tsc --noEmitand eslint report no errors or warnings forapps/roam. Production build completes with 0 errors.Enabledshows and hides the query builder; Legacy and Attributes are the last two groups.Loom video
https://www.loom.com/share/f76e4399d7784cf2a85613fd91301e78
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: group names and order follow the manager's review rather than the ticket text (see review focus above). The ticket should be updated to match.Local delegated full review
🤖 Generated with Claude Code