Fix reset password redirect#2926
Merged
Merged
Conversation
When a lost password request was submitted with the SSO login page, the link in the email wasn't redirecting the link with the key in the query correctly.
|
Code Review: No High or Medium issues found. This PR correctly fixes a real bug where DT's init hook was intercepting wp-login.php password-reset URLs (action=rp or action=resetpass) and stripping the key and login parameters on redirect to the DT login page, making password reset links useless. The fix uses sanitize_text_field(wp_unslash()) before passing values to add_query_arg(), which is appropriate since WP reset keys are alphanumeric and add_query_arg URL-encodes the values. The phpcs:disable suppression is correctly scoped, and wp_redirect() is consistent with the rest of the function. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a lost password request was submitted with the SSO login page, the link in the email wasn't redirecting the link with the key in the query correctly, resulting in an invalid key and the inability to actually reset the password.