Repository navigation
build: adopt stream-sdk npm publish workflow with OIDC - #5
Merged
haofeng0705 merged 2 commits intoSep 21, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
haofeng0705
requested changes
Sep 21, 2026
haofeng0705
left a comment
Contributor
There was a problem hiding this comment.
发布工作流结构正确,但 package.json 的 test 脚本重新加回了 Node 18 不支持的参数:
"node --test --test-force-exit --test-timeout=15000 --test-concurrency=1 ..."导致 Node Test (18.x) CI 失败:node: bad option: --test-force-exit、node: bad option: --test-timeout=15000。
请保持当前 main 上的兼容写法(仅保留 --test-concurrency=1):
"node --test --test-concurrency=1 test/channel.test.js ... test/download-to-file.test.js"另外两个小建议:
- 若启用 npm Trusted Publishing / provenance,发布命令建议加
--provenance。 - 为便于 npm Trusted Publisher 映射,可考虑给
buildjob 设置environment: npm(可选)。
…nance Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
已更新:
|
haofeng0705
approved these changes
Sep 21, 2026
haofeng0705
left a comment
Contributor
There was a problem hiding this comment.
复查通过:test 脚本保持 Node 18 兼容写法(仅 --test-concurrency=1),发布命令已加 --provenance 支持 npm Trusted Publishing;Node 18/20/22 CI 全绿,可合入。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the official
open-dingtalk/dingtalk-stream-sdk-nodejsrelease workflow and packaging:package.json(repository,homepage,bugs,files)..github/workflows/publish.ymlusing npm Trusted Publishing (OIDCid-token: write) and dynamic distribution tags (betavslatest).Test plan
npm pack --dry-runincludes only intended package files.publish.ymlmatchesopen-dingtalk/dingtalk-stream-sdk-nodejs.