Skip to content

docs: fix Java Maven coordinates to com.dingtalk:dingtalk-channel-sdk - #2

Merged
haofeng0705 merged 1 commit into
DingTalk-Real-AI:mainfrom
typefield:fix-java-maven-coords
Sep 20, 2026
Merged

haofeng0705 merged 1 commit into
DingTalk-Real-AI:mainfrom
typefield:fix-java-maven-coords

Conversation

@typefield

Copy link
Copy Markdown
Contributor

The cross-language install table (GUIDE.md:39, GUIDE.zh-CN.md:40) wrote the Java SDK coordinates as io.github.DingTalk-Real-AI:dingtalk-channel-sdk — not a resolvable artifact (and not the published coordinate).

Align it with the Java SDK migration in DingTalk-Real-AI/dingtalk-channel-sdk-java#1: Maven groupId com.dingtalk + package com.dingtalk.channel.

  • io.github.DingTalk-Real-AI:dingtalk-channel-sdk → com.dingtalk:dingtalk-channel-sdk

Docs-only change; no code affected.

@typefield

Copy link
Copy Markdown
Contributor Author

跨语言安装表中的 Java 坐标 io.github.DingTalk-Real-AI:dingtalk-channel-sdk 不是可解析的 artifact,对齐 java 仓库迁移后的 com.dingtalk:dingtalk-channel-sdk(仅 GUIDE.md:39 与 GUIDE.zh-CN.md:40 两处,纯文档改动,与 #3 互不冲突、可任意顺序合并)。@haofeng0705 请复查。

@haofeng0705 haofeng0705 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复查结论:暂缓合入。

GUIDE.md:39、GUIDE.zh-CN.md:40 已改为 com.dingtalk:dingtalk-channel-sdk,但 Java SDK 的迁移 PR #1 尚未合入,Maven Central 当前也无法解析该构件。此时合入会让文档给出不可安装的依赖。

建议先完成 Java SDK #1、发布并验证新坐标,再合入本 PR;或者在文档中明确标注该坐标尚未发布。npm test 本地 38/38 通过。

@haofeng0705 haofeng0705 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复查结论:请求修改。

GUIDE.md:39 和 GUIDE.zh-CN.md:40 的 Java Maven 坐标仍写为 io.github.DingTalk-Real-AI:dingtalk-channel-sdk,但本 PR 标题和提交说明是要改为 com.dingtalk:dingtalk-channel-sdk。当前文本与 Java SDK 迁移目标不一致。

另外,Java SDK #1 尚未合入,Maven Central 也查不到 com.dingtalk:dingtalk-channel-sdk 构件。建议:

  1. 将坐标统一改为 com.dingtalk:dingtalk-channel-sdk 并标注“待 Java SDK #1 发布后可安装”;或
  2. 保持旧坐标并修正 PR 标题/描述。

npm test 本地 38/38 通过。

@haofeng0705 haofeng0705 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复查:去掉无 lockfile 仓库的 setup-node npm cache,以及移除 Node 18 不支持的 test runner 参数,这两项修复均正确。将变更与当前 main 合并模拟后,Node 18 完整套件 45/45 通过。但该 fork 分支仍基于合入 #4 前的 main,当前处于冲突状态且未运行 CI。请先 rebase 到当前 main、解决冲突并等待 Node 18/20/22 CI 全绿后再复查。

@typefield
typefield force-pushed the fix-java-maven-coords branch from 3add9fa to 6474d68 Compare September 20, 2026 09:23
@typefield

typefield commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor Author

@haofeng0705 已 rebase 到当前 main,并解决合并冲突。最新 Node CI 已通过 Node 18/20/22 矩阵:https://github.com/typefield/dingtalk-channel-sdk-nodejs-1/actions/runs/35502196903 。请重新复查。

@haofeng0705 haofeng0705 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复查通过:已 rebase 到当前 main,保留 Maven 坐标统一、移除 npm cache、去掉 Node 18 不支持的 test runner 参数并修复 reconnect 用例清理;Node 18/20/22 CI 全绿,可合入。

@haofeng0705
haofeng0705 merged commit db6d2d5 into DingTalk-Real-AI:main Sep 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants