Repository navigation
docs: fix Java Maven coordinates to com.dingtalk:dingtalk-channel-sdk - #2
Conversation
|
跨语言安装表中的 Java 坐标 |
haofeng0705
left a comment
There was a problem hiding this comment.
复查结论:请求修改。
GUIDE.md:39 和 GUIDE.zh-CN.md:40 的 Java Maven 坐标仍写为 io.github.DingTalk-Real-AI:dingtalk-channel-sdk,但本 PR 标题和提交说明是要改为 com.dingtalk:dingtalk-channel-sdk。当前文本与 Java SDK 迁移目标不一致。
另外,Java SDK #1 尚未合入,Maven Central 也查不到 com.dingtalk:dingtalk-channel-sdk 构件。建议:
- 将坐标统一改为
com.dingtalk:dingtalk-channel-sdk并标注“待 Java SDK #1 发布后可安装”;或 - 保持旧坐标并修正 PR 标题/描述。
npm test 本地 38/38 通过。
haofeng0705
left a comment
There was a problem hiding this comment.
复查:去掉无 lockfile 仓库的 setup-node npm cache,以及移除 Node 18 不支持的 test runner 参数,这两项修复均正确。将变更与当前 main 合并模拟后,Node 18 完整套件 45/45 通过。但该 fork 分支仍基于合入 #4 前的 main,当前处于冲突状态且未运行 CI。请先 rebase 到当前 main、解决冲突并等待 Node 18/20/22 CI 全绿后再复查。
3add9fa to
6474d68
Compare
|
@haofeng0705 已 rebase 到当前 main,并解决合并冲突。最新 Node CI 已通过 Node 18/20/22 矩阵:https://github.com/typefield/dingtalk-channel-sdk-nodejs-1/actions/runs/35502196903 。请重新复查。 |
haofeng0705
left a comment
There was a problem hiding this comment.
复查通过:已 rebase 到当前 main,保留 Maven 坐标统一、移除 npm cache、去掉 Node 18 不支持的 test runner 参数并修复 reconnect 用例清理;Node 18/20/22 CI 全绿,可合入。
The cross-language install table (GUIDE.md:39, GUIDE.zh-CN.md:40) wrote the Java SDK coordinates as
io.github.DingTalk-Real-AI:dingtalk-channel-sdk— not a resolvable artifact (and not the published coordinate).Align it with the Java SDK migration in DingTalk-Real-AI/dingtalk-channel-sdk-java#1: Maven groupId
com.dingtalk+ packagecom.dingtalk.channel.io.github.DingTalk-Real-AI:dingtalk-channel-sdk→com.dingtalk:dingtalk-channel-sdkDocs-only change; no code affected.