Repository navigation
feat: show where to clean up deleted and missing videos - #952
Merged
Merged
Conversation
Once videos are marked deleted or missing, the Videos page hid them without saying where to clean them up, and a missing file's path was buried inside a sentence in a narrow tooltip. - Show "N deleted videos hidden" beside the Library heading on wide screens (under it on phones) with Show, Clean up and an explanation, and add a line under the Missing or Deleted filter when it isolates those videos. Each links to the Maintenance card at /settings/maintenance#deleted-and-missing, which the Maintenance page now scrolls to. - Render removed-video tooltips through a shared RemovalDescription that sets a missing file's path apart in a monospace pill, with a wider tooltip so it wraps less. The video modal keeps the plain sentence through the same describeMissing helper. - Move InfoHint to shared, since the Videos page now uses it too. Refs: #670
On hover, the Filters button on the Videos page and channel pages showed its label in nearly the same color as the hover background in some themes (Bold Flat light, Playful dark), so the text was hard to read. The Sort button and the channel filter button in the filter panel used the same hover classes. Switch them to the Button's neutral outlined style (color="inherit"), which already uses the foreground color on hover, and keep only the border highlight as an extra class. The Filters button still uses the primary fill while filters are active.
On desktop, the active filter chips stayed visible under the open inline filter panel, so each active filter appeared twice: as an editable control in the panel and as a summary chip beneath it. Show the chips only while the inline panel is closed. The mobile drawer is unchanged: it covers the page, so the chips keep their place rather than shifting the content behind it when it opens.
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit 630c175 |
dialmaster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #950. Once videos were hidden as deleted or marked missing, the Videos page didn't say where to go to clean them up, and a missing file's path was buried in the middle of a sentence in a narrow tooltip.