Repository navigation
fix: repair dead links across footer, routing, and guides - #5
Merged
Merged
Conversation
- Footer Resources links use <Link> (hash URLs) instead of plain hrefs that hit GitHub Pages' 404 and rendered Home. "Internships" now opens the visible quant-internship guide; "Campus Resources" removed (no such guide). - 404.html now redirects plain paths to hash routes (/about -> /#/about), keeping an existing #/ route when present. Drop dist/about/index.html, which loaded assets from /about/assets/ and rendered a blank page. - Quant-internship guide: replace invalid discord.gg/devilquant invite. - Getting-started guide: remove QuantStart callout (site returns 502). - leaders.json: drop expired LinkedIn CDN headshot URLs (Vaibhav Urs, Thomas Tse) and Thomas's unverified LinkedIn link.
This was referenced Oct 1, 2026
Contributor
Author
Performance resultsLighthouse, mobile preset (simulated slow 4G, 4x CPU), median of 3 runs, local Edge build served with gzip. Compared with
Verdict: no performance change expected or measured. This PR only changes links and the 404 redirect; About's code is identical to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Fixes dead links found in a full audit of devilquant.com (every external URL was checked with curl, and internal routes were checked against the live site).
<a href="/resources?...">. On GitHub Pages that path hits404.html, HashRouter sees no#/route and renders Home.<Link>(hash URLs). "Internships" → visiblelanding-a-quant-internshipguide (the oldlanding-an-internshipslug is hidden). "Campus Resources" removed: no such guide exists.devilquant.com/about/rendered a blank page. The build'sdist/about/index.htmlcopy loads./assets/..., which resolves to/about/assets/...(404).404.htmlis now a redirect:/about→/#/about,/resources?guide=x→/#/resources?guide=x. If the URL already has a#/route, that route wins.discord.gg/devilquant, which Discord's API reports as an Unknown Invite.discord.com/invite/WJbhDmumXp.null(placeholder) until real photo files are added. Removed Thomas's unverified LinkedIn link.The footer GitHub link (
github.com/DevilQuant) is intentionally left unchanged.How it was tested
npm run buildpasses;dist/about/is no longer generated.404.htmlredirect script against sample paths:/about,/about/,/resources?guide=…,/projects/.#/resources?guide=…, and the Internships link opens "Landing a Quant Internship".devilquant.com/aboutand the footer Resources links on the live site.Follow-ups
chore/add-ci-cd) follows.